Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 46043004: Fixes modifier handling for repeat keys. (Closed)

Created:
7 years, 1 month ago by rsadam
Modified:
7 years, 1 month ago
Reviewers:
kevers
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixes modifier handling for repeat keys. BUG=312344 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -28 lines) Patch
M ui/keyboard/resources/elements/kb-key-codes.html View 3 chunks +12 lines, -7 lines 0 comments Download
M ui/keyboard/resources/elements/kb-keyboard.html View 4 chunks +20 lines, -6 lines 0 comments Download
M ui/keyboard/resources/elements/kb-keyset.html View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/keyboard/resources/elements/kb-modifier-key.html View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/keyboard/resources/elements/kb-shift-key.html View 2 chunks +24 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rsadam
7 years, 1 month ago (2013-10-28 18:21:39 UTC) #1
kevers
lgtm
7 years, 1 month ago (2013-10-28 18:58:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/46043004/1
7 years, 1 month ago (2013-10-28 19:05:14 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-29 00:37:01 UTC) #4
Message was sent while issue was closed.
Change committed as 231462

Powered by Google App Engine
This is Rietveld 408576698