ui/keyboard/resources/elements/kb-keyset.html - Issue 46043004: Fixes modifier handling for repeat keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/keyboard/resources/elements/kb-keyset.html

Issue 46043004: Fixes modifier handling for repeat keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/keyboard/resources/elements/kb-keyset.html

diff --git a/ui/keyboard/resources/elements/kb-keyset.html b/ui/keyboard/resources/elements/kb-keyset.html

index 55d20c1f7124b307fced817c69d52bf743b4b54e..933e7ba3f90865764fab3d0dbd83ead156e4f5ba 100644

--- a/ui/keyboard/resources/elements/kb-keyset.html

+++ b/ui/keyboard/resources/elements/kb-keyset.html

@@ -27,6 +27,14 @@

nextKeyset: undefined,

// TODO(bshe): support select keyset on down, long and dbl events.

keyUp: function(event, detail) {

+ switch (detail.char) {

+ case 'Shift':

+ case 'Alt':

+ case 'Ctrl':

+ return;

+ default:

+ break;

+ }

if (!detail.toKeyset)

detail.toKeyset = this.nextKeyset;