Fixes modifier handling for repeat keys.

ui/keyboard/resources/elements/kb-key-codes.html

 <!--
   -- Copyright 2013 The Chromium Authors. All rights reserved.
   -- Use of this source code is governed by a BSD-style license that can be
   -- found in the LICENSE file.
   -->
 
 <polymer-element name="kb-key-codes">
 <script>
   (function() {
 
@@ skipping 11 matching lines @@
     var nextRequestID = 0;
 
     // Keycodes have been deprecated in the KeyEvent specification, but are
     // nonetheless required to support legacy web content.  The Keycodes in the
     // following table are based on subset of US-EN 101-key keyboard. These
     // codes are used in the absence of explicit keycodes for kb-key and
     // kb-keysequence elements. Keyboard layout authors may explicitly set the
     // keyCode attribute for kb-key or kb-keysequence elements to refer to
     // indices in this table in order to emulate a physical keyboard with an
     // alternate layout.  Not all keys on a virtual keyboard are required to
-    // have keyCodes.
+    // have keyCodes. The shiftModifier specifies whether to always include or
+    // exclude the shift modifer when sending key events for this key. If it's
+    // undefined, it will defer to state of the keyboard.
     // TODO(rsadam): Correctly propagate shutdown keycode. This is currently
     // ignored due to chromoting (crbug/146609)
     var keyCodes = {
       '\b': {keyCode: 0x08, shiftModifier: false},
       '\t': {keyCode: 0x09, shiftModifier: false},
       '\n': {keyCode: 0x0D, shiftModifier: false},
       'Esc': {keyCode: 0x1B, shiftModifier: false},
       ' ': {keyCode: 0x20, shiftModifier: false},
-      'Arrow-Left': {keyCode: 0x25, shiftModifier: false},
-      'Arrow-Up': {keyCode: 0x26, shiftModifier: false},
-      'Arrow-Right': {keyCode: 0x27, shiftModifier: false},
-      'Arrow-Down': {keyCode: 0x28, shiftModifier: false},
+      'Arrow-Left': {keyCode: 0x25, shiftModifier: undefined},
+      'Arrow-Up': {keyCode: 0x26, shiftModifier: undefined},
+      'Arrow-Right': {keyCode: 0x27, shiftModifier: undefined},
+      'Arrow-Down': {keyCode: 0x28, shiftModifier: undefined},
       '0': {keyCode: 0x30, shiftModifier: false},
       ')': {keyCode: 0x30, shiftModifier: true},
       '1': {keyCode: 0x31, shiftModifier: false},
       '!': {keyCode: 0x31, shiftModifier: true},
       '2': {keyCode: 0x32, shiftModifier: false},
       '@': {keyCode: 0x32, shiftModifier: true},
       '3': {keyCode: 0x33, shiftModifier: false},
       '#': {keyCode: 0x33, shiftModifier: true},
       '4': {keyCode: 0x34, shiftModifier: false},
       '$': {keyCode: 0x34, shiftModifier: true},
@@ skipping 124 matching lines @@
       * @param {string} type The type of key event, which may be keydown
       *     or keyup.
       * @return {?KeyboardEvent} A KeyboardEvent object, or undefined on
       *     failure.
       */
      createVirtualKeyEvent: function(detail, type) {
        var char = detail.char;
        var keyCode = detail.keyCode;
        // The shift modifier is handled specially. Some charactares like '+'
        // {keyCode: 0xBB, shiftModifier: true}, are available on non-upper
-       // keysets, and so we rely on caching the correct shiftModifier.
+       // keysets, and so we rely on caching the correct shiftModifier. If
+       // the cached value of the shiftModifier is undefined, we defer to
+       // the shiftModifier in the detail.
        var shiftModifier = detail.shiftModifier;
        if (keyCode == undefined) {
          var state = this.GetKeyCodeAndModifiers(char);
          if (state) {
            keyCode = state.keyCode;
-           shiftModifier = state.shiftModifier;
+           shiftModifier = (state.shiftModifier == undefined) ?
+               shiftModifier : state.shiftModifier;
          } else {
            // Keycode not defined.
            return;
          }
        }
        var modifiers = Modifier.NONE;
        modifiers = shiftModifier ? modifiers | Modifier.SHIFT : modifiers;
        modifiers = detail.controlModifier ?
            modifiers | Modifier.CONTROL : modifiers;
        modifiers = detail.altModifier ? modifiers | Modifier.ALT : modifiers;
        return {
          type: type,
          charValue: char.charCodeAt(0),
          keyCode: keyCode,
          modifiers: modifiers
        };
      },
     });
   })();
 </script>
 </polymer-element>