ui/keyboard/resources/elements/kb-modifier-key.html - Issue 46043004: Fixes modifier handling for repeat keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/keyboard/resources/elements/kb-modifier-key.html

Issue 46043004: Fixes modifier handling for repeat keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/keyboard/resources/elements/kb-modifier-key.html

diff --git a/ui/keyboard/resources/elements/kb-modifier-key.html b/ui/keyboard/resources/elements/kb-modifier-key.html

index 343a5940d2dadac61b5b3648f4687899c2a3dad2..ebe9cf79e3aef86385003a481b6624a3b34c14c9 100644

--- a/ui/keyboard/resources/elements/kb-modifier-key.html

+++ b/ui/keyboard/resources/elements/kb-modifier-key.html

@@ -64,10 +64,10 @@

/**

- * Notifies key that a non-control keyed up.

+ * Notifies key that a non-control keyed was typed.

* A control key is defined as one of shift, control or alt.

- onNonControlKeyUp: function() {

+ onNonControlKeyTyped: function() {

switch(this.state) {

case (KEY_STATES.TAPPED):

this.state = KEY_STATES.UNLOCKED;