Add MinidumpMemoryWriter, MinidumpMemoryListWriter, and their test

Add MinidumpMemoryWriter, MinidumpMemoryListWriter, and their test.

TEST=minidump_test MinidumpMemoryWriter
R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/3b2c6d32f481

[Robert Sesek, 2014-08-11 22:24:00]

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
File minidump/minidump_memory_writer.cc (right):

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
minidump/minidump_memory_writer.cc:82: registered_memory_descriptors_) {
nit: indent +4

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
minidump/minidump_memory_writer.cc:112: return AddExtraMemory(memory_writer);
AddExtraMemory returns void.

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
minidump/minidump_memory_writer.cc:166: iov.iov_len =
sizeof(MINIDUMP_MEMORY_DESCRIPTOR);
Move this into the loop body and you can remove the empty check.

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
File minidump/minidump_memory_writer.h (right):

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
minidump/minidump_memory_writer.h:38: class MinidumpMemoryWriter : public
internal::MinidumpWritable {
I understand why these two classes share a file, but it may help to draw
distinction between them if they were split.

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
minidump/minidump_memory_writer.h:71: //! Memory regions are aligned to a
16-byte boundary. The actual alignment
This is required on Mac, but will this vary on other platforms. I.e. is that a
requirement of the minidump?

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
minidump/minidump_memory_writer.h:91: virtual Phase WritePhase() override;
final?

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
minidump/minidump_memory_writer.h:93: //! \brief Returns the base address of the
memory region in the addres space
sp: address

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
minidump/minidump_memory_writer.h:93: //! \brief Returns the base address of the
memory region in the addres space
I'd move these two methods above the MinidumpWritable section, since they're
critical to the understanding of this class.

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
File minidump/minidump_memory_writer_test.cc (right):

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
minidump/minidump_memory_writer_test.cc:49:
EXPECT_EQ(static_cast<uint32_t>(MINIDUMP_SIGNATURE), header->Signature);
This code gets repeated a lot in other tests. Perhaps a function to compare (the
interesting fields of) MINIDUMP_HEADERs?

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
minidump/minidump_memory_writer_test.cc:135: return true;
return rv?

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
minidump/minidump_memory_writer_test.cc:369: EXPECT_EQ(0u,
memory_list->MemoryRanges[1].Memory.Rva % 16);
A small helper to verify that a MemoryRange is valid seems smart.

[Mark Mentovai, 2014-08-12 01:04:01]

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
File minidump/minidump_memory_writer.h (right):

https://codereview.chromium.org/459973002/diff/1/minidump/minidump_memory_wri...
minidump/minidump_memory_writer.h:71: //! Memory regions are aligned to a
16-byte boundary. The actual alignment
rsesek wrote:
> This is required on Mac, but will this vary on other platforms. I.e. is that a
> requirement of the minidump?

Not a requirement of the minidump, it just makes processing the file a little
easier.

[Robert Sesek, 2014-08-12 17:10:47]

LGTM

[Mark Mentovai, 2014-08-12 17:26:44]

Committed patchset #2 manually as 3b2c6d32f481 (presubmit successful).