minidump/minidump_writable.h - Issue 459973002: Add MinidumpMemoryWriter, MinidumpMemoryListWriter, and their test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_writable.h

Issue 459973002: Add MinidumpMemoryWriter, MinidumpMemoryListWriter, and their test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Address review feedback Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_writable.h

diff --git a/minidump/minidump_writable.h b/minidump/minidump_writable.h

index 32ed81e714d3c73f7c06506fd138af2f12b87ed9..15876d4896acede4bb6210620d9be13e2a21612a 100644

--- a/minidump/minidump_writable.h

+++ b/minidump/minidump_writable.h

@@ -259,8 +259,11 @@ class MinidumpWritable {

virtual bool WriteObject(FileWriterInterface* file_writer) = 0;

private:

- std::vector<RVA*> registered_rvas_;

+ std::vector<RVA*> registered_rvas_; // weak

+ // weak

std::vector<MINIDUMP_LOCATION_DESCRIPTOR*> registered_location_descriptors_;

size_t leading_pad_bytes_;

State state_;

« no previous file with comments | « minidump/minidump_test_util.cc ('k') | minidump/minidump_writable_test.cc » ('j') | no next file with comments »