Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: minidump/minidump_system_info_writer_test.cc

Issue 459973002: Add MinidumpMemoryWriter, MinidumpMemoryListWriter, and their test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_misc_info_writer_test.cc ('k') | minidump/minidump_test_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "minidump/minidump_system_info_writer.h" 15 #include "minidump/minidump_system_info_writer.h"
16 16
17 #include <dbghelp.h> 17 #include <dbghelp.h>
18 #include <string.h> 18 #include <string.h>
19 19
20 #include <string> 20 #include <string>
21 21
22 #include "gtest/gtest.h" 22 #include "gtest/gtest.h"
23 #include "minidump/minidump_file_writer.h" 23 #include "minidump/minidump_file_writer.h"
24 #include "minidump/minidump_test_util.h"
24 #include "util/file/string_file_writer.h" 25 #include "util/file/string_file_writer.h"
25 26
26 namespace { 27 namespace {
27 28
28 using namespace crashpad; 29 using namespace crashpad;
30 using namespace crashpad::test;
29 31
30 void GetSystemInfoStream(const std::string& file_contents, 32 void GetSystemInfoStream(const std::string& file_contents,
31 size_t csd_version_length, 33 size_t csd_version_length,
32 const MINIDUMP_SYSTEM_INFO** system_info, 34 const MINIDUMP_SYSTEM_INFO** system_info,
33 const MINIDUMP_STRING** csd_version) { 35 const MINIDUMP_STRING** csd_version) {
34 // The expected number of bytes for the CSD version’s MINIDUMP_STRING::Buffer. 36 // The expected number of bytes for the CSD version’s MINIDUMP_STRING::Buffer.
35 const size_t kCSDVersionBytes = 37 const size_t kCSDVersionBytes =
36 csd_version_length * sizeof(MINIDUMP_STRING::Buffer[0]); 38 csd_version_length * sizeof(MINIDUMP_STRING::Buffer[0]);
37 const size_t kCSDVersionBytesWithNUL = 39 const size_t kCSDVersionBytesWithNUL =
38 kCSDVersionBytes + sizeof(MINIDUMP_STRING::Buffer[0]); 40 kCSDVersionBytes + sizeof(MINIDUMP_STRING::Buffer[0]);
39 41
40 const size_t kDirectoryOffset = sizeof(MINIDUMP_HEADER); 42 const size_t kDirectoryOffset = sizeof(MINIDUMP_HEADER);
41 const size_t kSystemInfoStreamOffset = 43 const size_t kSystemInfoStreamOffset =
42 kDirectoryOffset + sizeof(MINIDUMP_DIRECTORY); 44 kDirectoryOffset + sizeof(MINIDUMP_DIRECTORY);
43 const size_t kCSDVersionOffset = 45 const size_t kCSDVersionOffset =
44 kSystemInfoStreamOffset + sizeof(MINIDUMP_SYSTEM_INFO); 46 kSystemInfoStreamOffset + sizeof(MINIDUMP_SYSTEM_INFO);
45 const size_t kFileSize = 47 const size_t kFileSize =
46 kCSDVersionOffset + sizeof(MINIDUMP_STRING) + kCSDVersionBytesWithNUL; 48 kCSDVersionOffset + sizeof(MINIDUMP_STRING) + kCSDVersionBytesWithNUL;
47 49
48 ASSERT_EQ(kFileSize, file_contents.size()); 50 ASSERT_EQ(kFileSize, file_contents.size());
49 51
50 const MINIDUMP_HEADER* header = 52 const MINIDUMP_HEADER* header =
51 reinterpret_cast<const MINIDUMP_HEADER*>(&file_contents[0]); 53 reinterpret_cast<const MINIDUMP_HEADER*>(&file_contents[0]);
52 54
53 EXPECT_EQ(static_cast<uint32_t>(MINIDUMP_SIGNATURE), header->Signature); 55 VerifyMinidumpHeader(header, 1, 0);
54 EXPECT_EQ(static_cast<uint32_t>(MINIDUMP_VERSION), header->Version); 56 if (testing::Test::HasFatalFailure()) {
55 ASSERT_EQ(1u, header->NumberOfStreams); 57 return;
56 ASSERT_EQ(kDirectoryOffset, header->StreamDirectoryRva); 58 }
57 EXPECT_EQ(0u, header->CheckSum);
58 EXPECT_EQ(0u, header->TimeDateStamp);
59 EXPECT_EQ(MiniDumpNormal, header->Flags);
60 59
61 const MINIDUMP_DIRECTORY* directory = 60 const MINIDUMP_DIRECTORY* directory =
62 reinterpret_cast<const MINIDUMP_DIRECTORY*>( 61 reinterpret_cast<const MINIDUMP_DIRECTORY*>(
63 &file_contents[kDirectoryOffset]); 62 &file_contents[kDirectoryOffset]);
64 63
65 ASSERT_EQ(kMinidumpStreamTypeSystemInfo, directory->StreamType); 64 ASSERT_EQ(kMinidumpStreamTypeSystemInfo, directory->StreamType);
66 ASSERT_EQ(sizeof(MINIDUMP_SYSTEM_INFO), directory->Location.DataSize); 65 ASSERT_EQ(sizeof(MINIDUMP_SYSTEM_INFO), directory->Location.DataSize);
67 ASSERT_EQ(kSystemInfoStreamOffset, directory->Location.Rva); 66 ASSERT_EQ(kSystemInfoStreamOffset, directory->Location.Rva);
68 67
69 *system_info = reinterpret_cast<const MINIDUMP_SYSTEM_INFO*>( 68 *system_info = reinterpret_cast<const MINIDUMP_SYSTEM_INFO*>(
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 MinidumpFileWriter minidump_file_writer; 288 MinidumpFileWriter minidump_file_writer;
290 MinidumpSystemInfoWriter system_info_writer; 289 MinidumpSystemInfoWriter system_info_writer;
291 minidump_file_writer.AddStream(&system_info_writer); 290 minidump_file_writer.AddStream(&system_info_writer);
292 291
293 StringFileWriter file_writer; 292 StringFileWriter file_writer;
294 ASSERT_DEATH(minidump_file_writer.WriteEverything(&file_writer), 293 ASSERT_DEATH(minidump_file_writer.WriteEverything(&file_writer),
295 "csd_version_"); 294 "csd_version_");
296 } 295 }
297 296
298 } // namespace 297 } // namespace
OLDNEW
« no previous file with comments | « minidump/minidump_misc_info_writer_test.cc ('k') | minidump/minidump_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698