Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: minidump/minidump_writable_test.cc

Issue 459973002: Add MinidumpMemoryWriter, MinidumpMemoryListWriter, and their test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_writable.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_writable_test.cc
diff --git a/minidump/minidump_writable_test.cc b/minidump/minidump_writable_test.cc
index 616f8cd8c716d2414101801710856893f13659cc..fb52334dbd9389327ce329665c2cab20b9e03e0b 100644
--- a/minidump/minidump_writable_test.cc
+++ b/minidump/minidump_writable_test.cc
@@ -133,8 +133,9 @@ class TestStringMinidumpWritable final : public BaseTestMinidumpWritable {
virtual bool WriteObject(FileWriterInterface* file_writer) override {
BaseTestMinidumpWritable::WriteObject(file_writer);
- EXPECT_TRUE(file_writer->Write(&data_[0], data_.size()));
- return true;
+ bool rv = file_writer->Write(&data_[0], data_.size());
+ EXPECT_TRUE(rv);
+ return rv;
}
private:
« no previous file with comments | « minidump/minidump_writable.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698