Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 459493002: Revert of Extend contextMenus API to support browser/page actions (Closed)

Created:
6 years, 4 months ago by tommycli
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Extend contextMenus API to support browser/page actions (https://codereview.chromium.org/359493005/) Reason for revert: This adds two new static initializers, and breaks the perf bot. See http://build.chromium.org/p/chromium/builders/Linux%20x64 Good: http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/68460 Bad: http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/68461 # Static initializers in src/out/Release/chrome: ... # context_menu_matcher.cc extensions::(anonymous namespace)::action_menu_top_level_limit # context_menu_matcher.cc __init_array_end+0xd950 ... # Found 36 static initializers in 8 files. Original issue's description: > Extend contextMenus API to support browser/page actions > > Screenshot: > http://i.imgur.com/RILqQqe.png > > BUG=234425 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -364 lines) Patch
M chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h View 3 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/context_menus/context_menus_api_helpers.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/context_menu_matcher.h View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/extensions/context_menu_matcher.cc View 7 chunks +16 lines, -51 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.h View 5 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 8 chunks +8 lines, -88 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model_unittest.cc View 4 chunks +12 lines, -132 lines 0 comments Download
M chrome/browser/extensions/menu_manager.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/menu_manager_factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/menu_manager_factory.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 4 chunks +17 lines, -15 lines 0 comments Download
M chrome/browser/ui/app_list/app_context_menu.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/context_menus.json View 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/common/extensions/api/web_view_internal.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tommycli
Created Revert of Extend contextMenus API to support browser/page actions
6 years, 4 months ago (2014-08-08 20:30:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/459493002/1
6 years, 4 months ago (2014-08-08 20:33:12 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 20:33:13 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-08 20:33:14 UTC) #4
Yoyo Zhou
6 years, 4 months ago (2014-08-08 20:51:09 UTC) #5
FYI, luken@ reverted this already.

Powered by Google App Engine
This is Rietveld 408576698