chrome/browser/extensions/menu_manager_factory.cc - Issue 459493002: Revert of Extend contextMenus API to support browser/page actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/menu_manager_factory.cc

Issue 459493002: Revert of Extend contextMenus API to support browser/page actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/menu_manager_factory.h ('k') | chrome/browser/renderer_context_menu/render_view_context_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/menu_manager_factory.cc

diff --git a/chrome/browser/extensions/menu_manager_factory.cc b/chrome/browser/extensions/menu_manager_factory.cc

index 33c3f74f075f097b2fac455e659abce66039196e..60fa844d99f4afbecae48e7d9fa0bf3086edc5fa 100644

--- a/chrome/browser/extensions/menu_manager_factory.cc

+++ b/chrome/browser/extensions/menu_manager_factory.cc

@@ -25,12 +25,6 @@

return Singleton<MenuManagerFactory>::get();

}

-// static

-KeyedService* MenuManagerFactory::BuildServiceInstanceForTesting(

- content::BrowserContext* context) {

- return GetInstance()->BuildServiceInstanceFor(context);

MenuManagerFactory::MenuManagerFactory()

: BrowserContextKeyedServiceFactory(

"MenuManager",

@@ -43,7 +37,9 @@

KeyedService* MenuManagerFactory::BuildServiceInstanceFor(

content::BrowserContext* context) const {

Profile* profile = Profile::FromBrowserContext(context);

- return new MenuManager(profile, ExtensionSystem::Get(profile)->state_store());

+ return new MenuManager(

+ profile,

+ ExtensionSystem::Get(profile)->state_store());

}

content::BrowserContext* MenuManagerFactory::GetBrowserContextToUse(