chrome/browser/extensions/context_menu_matcher.h - Issue 459493002: Revert of Extend contextMenus API to support browser/page actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/context_menu_matcher.h

Issue 459493002: Revert of Extend contextMenus API to support browser/page actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/context_menus/context_menus_api_helpers.cc ('k') | chrome/browser/extensions/context_menu_matcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/context_menu_matcher.h

diff --git a/chrome/browser/extensions/context_menu_matcher.h b/chrome/browser/extensions/context_menu_matcher.h

index ef44dac9df0512aaccb23ae7b66d06cd5d450631..f3f631fc9181eba56f0cee0fb596fec505da4ee7 100644

--- a/chrome/browser/extensions/context_menu_matcher.h

+++ b/chrome/browser/extensions/context_menu_matcher.h

@@ -43,13 +43,10 @@

// This is a helper function to append items for one particular extension.

// The |index| parameter is used for assigning id's, and is incremented for

- // each item actually added. |is_action_menu| is used for browser and page

- // action context menus, in which menu items are not placed in submenus

- // and the extension's icon is not shown.

+ // each item actually added.

void AppendExtensionItems(const MenuItem::ExtensionKey& extension_key,

const base::string16& selection_text,

- int* index,

- bool is_action_menu);

+ int* index);

void Clear();

@@ -83,8 +80,7 @@

bool can_cross_incognito,

const base::string16& selection_text,

ui::SimpleMenuModel* menu_model,

- int* index,

- bool is_action_menu_top_level);

+ int* index);

// Attempts to get an MenuItem given the id of a context menu item.

extensions::MenuItem* GetExtensionMenuItem(int id) const;