Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 458193002: Revert 23028 - "MIPS: Add support for arch. revision 6 to mips32 port." (Closed)

Created:
6 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, dusmil.imgtec
Project:
v8
Visibility:
Public.

Description

Revert 23028 - "MIPS: Add support for arch. revision 6 to mips32 port." Breaks compilation of ARM64. | Additional summary: | - Introduce fp64 fpu mode into mips32 port required for r6. | - Implement runtime detections for fpu mode and arch. revision to preserve | compatibility with previous architecture revisions. | | TEST= | BUG= | R=jkummerow@chromium.org, paul.lind@imgtec.com | | Review URL: https://codereview.chromium.org/453043002 BUG=none LOG=n TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+494 lines, -2481 lines) Patch
M build/toolchain.gypi View 5 chunks +1 line, -99 lines 0 comments Download
M src/base/atomicops_internals_mips_gcc.h View 3 chunks +18 lines, -19 lines 0 comments Download
M src/base/cpu.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/base/cpu.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/mips/assembler-mips.h View 9 chunks +1 line, -134 lines 0 comments Download
M src/mips/assembler-mips.cc View 28 chunks +44 lines, -470 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +10 lines, -22 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/constants-mips.h View 14 chunks +4 lines, -124 lines 0 comments Download
M src/mips/constants-mips.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M src/mips/disasm-mips.cc View 18 chunks +48 lines, -360 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 15 chunks +28 lines, -17 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips/lithium-mips.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 4 chunks +3 lines, -31 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 26 chunks +74 lines, -433 lines 0 comments Download
M src/mips/simulator-mips.h View 2 chunks +4 lines, -10 lines 0 comments Download
M src/mips/simulator-mips.cc View 33 chunks +144 lines, -489 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 8 chunks +56 lines, -79 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 4 chunks +43 lines, -138 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 4 months ago (2014-08-11 11:00:57 UTC) #1
jochen (gone - plz use gerrit)
Committed patchset #1 manually as 23030.
6 years, 4 months ago (2014-08-11 11:01:22 UTC) #2
Jakob Kummerow
lgtm
6 years, 4 months ago (2014-08-11 11:01:40 UTC) #3
Jakob Kummerow
6 years, 4 months ago (2014-08-11 11:03:00 UTC) #4
Message was sent while issue was closed. 
+Dusan FYI.

Powered by Google App Engine
This is Rietveld 408576698