Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 456283002: Revert of [SVG2] Make transform, gradientTransform and patternTransform presentation attributes. (Closed)

Created:
6 years, 4 months ago by Erik Dahlström (inactive)
Modified:
6 years, 4 months ago
Reviewers:
pdr., krit
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of [SVG2] Make transform, gradientTransform and patternTransform presentation attributes. (https://codereview.chromium.org/423093014/) Reason for revert: Caused 10-50% performance regressions on svg, see http://crbug.com/402133. Original issue's description: > [SVG2] Make transform, gradientTransform and patternTransform presentation attributes. > > Spec: > http://www.w3.org/TR/css3-transforms/#svg-transform > http://www.w3.org/TR/css3-transforms/#svg-syntax > http://www.w3.org/TR/css3-transforms/#svg-gradient-transform-pattern-transform > > BUG=369942 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179702 TBR=dschulze@chromium.org,pdr@chromium.org NOTREECHECKS=true NOTRY=true BUG=369942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -369 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/svg/custom/gradient-transform-invalid.svg View 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/svg/custom/gradient-transform-invalid-expected.svg View 1 chunk +0 lines, -70 lines 0 comments Download
M LayoutTests/svg/custom/transform-invalid.svg View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/svg/custom/transform-invalid-expected.txt View 2 chunks +26 lines, -24 lines 0 comments Download
D LayoutTests/svg/transforms/gradient-transform-inline-style.svg View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/svg/transforms/gradient-transform-inline-style-expected.svg View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/svg/transforms/gradient-transform-no-override.svg View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/svg/transforms/gradient-transform-no-override-2.svg View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/svg/transforms/gradient-transform-no-override-2-expected.svg View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/svg/transforms/gradient-transform-no-override-expected.svg View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/svg/transforms/translate-with-units.svg View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/svg/transforms/translate-with-units-expected.svg View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/svg/transforms/translate-without-units.svg View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/svg/transforms/translate-without-units-expected.svg View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/svg/GradientAttributes.h View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -33 lines 0 comments Download
M Source/core/svg/SVGGradientElement.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGGradientElement.cpp View 2 chunks +0 lines, -20 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.cpp View 3 chunks +28 lines, -18 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPatternElement.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 3 chunks +3 lines, -31 lines 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Erik Dahlström (inactive)
Created Revert of [SVG2] Make transform, gradientTransform and patternTransform presentation attributes.
6 years, 4 months ago (2014-08-11 07:55:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/456283002/1
6 years, 4 months ago (2014-08-11 07:56:38 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 07:57:07 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-08-11 07:57:11 UTC) #4
pdr.
On 2014/08/11 07:57:11, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 4 months ago (2014-08-11 16:37:58 UTC) #5
pdr.
6 years, 4 months ago (2014-08-11 23:07:41 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/459053002 landed so I've closed this review.

Powered by Google App Engine
This is Rietveld 408576698