Issue 459053002: Revert of [SVG2] Make transform, gradientTransform and patternTransform presentation attributes. (h…

Issue 459053002: Revert of [SVG2] Make transform, gradientTransform and patternTransform presentation attributes. (h… (Closed)

Created:
6 years, 4 months ago by pdr.

Modified:
6 years, 4 months ago

Reviewers:
krit, pdr., Erik Dahlström (inactive)

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Description

Revert of [SVG2] Make transform, gradientTransform and patternTransform presentation attributes. Reason for revert: Caused 10-50% performance regressions on svg, see http://crbug.com/402133. Original issue's description: > [SVG2] Make transform, gradientTransform and patternTransform presentation attributes. > > Spec: > http://www.w3.org/TR/css3-transforms/#svg-transform > http://www.w3.org/TR/css3-transforms/#svg-syntax > http://www.w3.org/TR/css3-transforms/#svg-gradient-transform-pattern-transform > > BUG=369942 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179702 TBR=dschulze@chromium.org,ed@opera.com NOTREECHECKS=true BUG=369942 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179998

Patch Set 1 #

Patch Set 2 : Add missing expectation #

Created: 6 years, 4 months ago

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -366 lines)
M	LayoutTests/TestExpectations	View	1 chunk	+2 lines, -0 lines	0 comments
D	LayoutTests/svg/custom/gradient-transform-invalid.svg	View	1 chunk	+0 lines, -70 lines	0 comments
D	LayoutTests/svg/custom/gradient-transform-invalid-expected.svg	View	1 chunk	+0 lines, -70 lines	0 comments
M	LayoutTests/svg/custom/transform-invalid.svg	View	1 chunk	+1 line, -0 lines	0 comments
M	LayoutTests/svg/custom/transform-invalid-expected.txt	View	2 chunks	+26 lines, -24 lines	0 comments
D	LayoutTests/svg/transforms/gradient-transform-inline-style.svg	View	1 chunk	+0 lines, -9 lines	0 comments
D	LayoutTests/svg/transforms/gradient-transform-inline-style-expected.svg	View	1 chunk	+0 lines, -9 lines	0 comments
D	LayoutTests/svg/transforms/gradient-transform-no-override.svg	View	1 chunk	+0 lines, -9 lines	0 comments
D	LayoutTests/svg/transforms/gradient-transform-no-override-2.svg	View	1 chunk	+0 lines, -9 lines	0 comments
D	LayoutTests/svg/transforms/gradient-transform-no-override-2-expected.svg	View	1 chunk	+0 lines, -9 lines	0 comments
D	LayoutTests/svg/transforms/gradient-transform-no-override-expected.svg	View	1 chunk	+0 lines, -9 lines	0 comments
D	LayoutTests/svg/transforms/translate-with-units.svg	View	1 chunk	+0 lines, -5 lines	0 comments
D	LayoutTests/svg/transforms/translate-with-units-expected.svg	View	1 chunk	+0 lines, -4 lines	0 comments
D	LayoutTests/svg/transforms/translate-without-units.svg	View	1 chunk	+0 lines, -5 lines	0 comments
D	LayoutTests/svg/transforms/translate-without-units-expected.svg	View	1 chunk	+0 lines, -4 lines	0 comments
M	Source/core/svg/GradientAttributes.h	View	1 chunk	+0 lines, -15 lines	0 comments
M	Source/core/svg/SVGElement.h	View	1 chunk	+0 lines, -2 lines	0 comments
M	Source/core/svg/SVGElement.cpp	View	1 chunk	+0 lines, -32 lines	0 comments
M	Source/core/svg/SVGGradientElement.h	View	1 chunk	+0 lines, -3 lines	0 comments
M	Source/core/svg/SVGGradientElement.cpp	View	2 chunks	+0 lines, -20 lines	0 comments
M	Source/core/svg/SVGGraphicsElement.h	View	1 chunk	+0 lines, -2 lines	0 comments
M	Source/core/svg/SVGGraphicsElement.cpp	View	3 chunks	+28 lines, -18 lines	0 comments
M	Source/core/svg/SVGLinearGradientElement.cpp	View	1 chunk	+4 lines, -2 lines	0 comments
M	Source/core/svg/SVGPatternElement.h	View	1 chunk	+0 lines, -3 lines	0 comments
M	Source/core/svg/SVGPatternElement.cpp	View	3 chunks	+3 lines, -31 lines	0 comments
M	Source/core/svg/SVGRadialGradientElement.cpp	View	1 chunk	+4 lines, -2 lines	0 comments