Re-land of: Allow paint invalidation containers to cross frame boundaries.

Re-land of: Allow paint invalidation containers to cross frame boundaries.

The previous version had an infinite loop bug in RenderObject when there are two nested frames.

Previously, the *actual* paint invalidation container, meaning the enclosing
compositing layer / root RenderView, could already have been across a frame boundary. The logic to do this correctly was done via special code in RenderView.

Instead, generalize the existing mechanisms to find a paint invalidation container
and map rects to repaint container coordinate space to cross frame boundaries.
This simplifies the code, and also causes paint invalidation rects to always be stored
in the coordinate space of their graphics layer backing. The latter is important if we want
to use these rects for determining which parts of a graphics layer need to be painted.

BUG=401156
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179858

[chrishtr, 2014-08-08 17:57:54]

https://codereview.chromium.org/455883002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderObject.cpp (right):

https://codereview.chromium.org/455883002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderObject.cpp:1457: renderView =
renderView->frame()->ownerRenderer()->view();
Changed line.

[leviw_travelin_and_unemployed, 2014-08-08 18:06:31]

The CQ bit was checked by leviw@chromium.org

[commit-bot: I haz the power, 2014-08-08 18:07:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishtr@chromium.org/455883002/1

[commit-bot: I haz the power, 2014-08-08 18:07:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 18:07:16]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[leviw_travelin_and_unemployed, 2014-08-08 18:07:53]

lgtm

https://codereview.chromium.org/455883002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderObject.cpp (right):

https://codereview.chromium.org/455883002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderObject.cpp:1457: renderView =
renderView->frame()->ownerRenderer()->view();
This seems better ;)

lgtm

[chrishtr, 2014-08-08 18:13:07]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-08-08 18:13:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishtr@chromium.org/455883002/1

[commit-bot: I haz the power, 2014-08-08 19:27:39]

Change committed as 179858

[leviw_travelin_and_unemployed, 2014-08-14 23:39:02]

A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/469383003/ by leviw@chromium.org.

The reason for reverting is: Broke iframe repainting:
https://code.google.com/p/chromium/issues/detail?id=403734..