Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 455523002: [Checkstyle] Update static variable and constant names to match style guides. (Closed)

Created:
6 years, 4 months ago by aurimas (slooooooooow)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, jam, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Checkstyle] Update static variable and constant names to match style guides. - Static field names start with s. - static final fields (constants) are ALL_CAPS_WITH_UNDERSCORES. http://source.android.com/source/code-style.html#follow-field-naming-conventions BUG=318404 TBR=qinmin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288416

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : Rebase #

Patch Set 4 : yfriendman's nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -82 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwResource.java View 2 chunks +12 lines, -12 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/permission/AwPermissionRequest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateOptionsTest.java View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/InfoBarTestAnimationListener.java View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/InputDialogContainerTest.java View 3 chunks +18 lines, -17 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/NestedSystemMessageHandler.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/MockLocationProvider.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java View 2 chunks +4 lines, -4 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureFactory.java View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureTango.java View 3 chunks +6 lines, -6 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/HelpActivity.java View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M tools/android/checkstyle/chromium-style-5.0.xml View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
aurimas (slooooooooow)
boliu@chromium.org: Please review changes in android_webview qinmin@chromium.org: Please review changes in media yfriedman@chromium.org: Please review ...
6 years, 4 months ago (2014-08-08 05:41:08 UTC) #1
aurimas (slooooooooow)
lambroslambrou@chromium.org: Please review changes in remoting/
6 years, 4 months ago (2014-08-08 05:43:45 UTC) #2
mkosiba (inactive)
android_webview/ LGTM
6 years, 4 months ago (2014-08-08 09:30:07 UTC) #3
Lambros
remoting/ lgtm
6 years, 4 months ago (2014-08-08 17:13:35 UTC) #4
Yaron
lgtm looked at media too https://codereview.chromium.org/455523002/diff/20001/content/public/test/android/javatests/src/org/chromium/content/browser/test/NestedSystemMessageHandler.java File content/public/test/android/javatests/src/org/chromium/content/browser/test/NestedSystemMessageHandler.java (right): https://codereview.chromium.org/455523002/diff/20001/content/public/test/android/javatests/src/org/chromium/content/browser/test/NestedSystemMessageHandler.java#newcode31 content/public/test/android/javatests/src/org/chromium/content/browser/test/NestedSystemMessageHandler.java:31: private static final Handler ...
6 years, 4 months ago (2014-08-08 17:35:44 UTC) #5
aurimas (slooooooooow)
https://codereview.chromium.org/455523002/diff/20001/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/MockLocationProvider.java File content/public/test/android/javatests/src/org/chromium/content/browser/test/util/MockLocationProvider.java (right): https://codereview.chromium.org/455523002/diff/20001/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/MockLocationProvider.java#newcode23 content/public/test/android/javatests/src/org/chromium/content/browser/test/util/MockLocationProvider.java:23: private static final Object sLock = new Object(); On ...
6 years, 4 months ago (2014-08-08 17:41:53 UTC) #6
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 4 months ago (2014-08-08 17:42:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/455523002/60001
6 years, 4 months ago (2014-08-08 17:44:15 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 19:27:08 UTC) #9
Message was sent while issue was closed. 
Change committed as 288416

Powered by Google App Engine
This is Rietveld 408576698