remoting/android/java/src/org/chromium/chromoting/HelpActivity.java - Issue 455523002: [Checkstyle] Update static variable and constant names to match style guides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/android/java/src/org/chromium/chromoting/HelpActivity.java

Issue 455523002: [Checkstyle] Update static variable and constant names to match style guides. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: yfriendman's nits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/base/android/java/src/org/chromium/media/VideoCaptureTango.java ('k') | tools/android/checkstyle/chromium-style-5.0.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/android/java/src/org/chromium/chromoting/HelpActivity.java

diff --git a/remoting/android/java/src/org/chromium/chromoting/HelpActivity.java b/remoting/android/java/src/org/chromium/chromoting/HelpActivity.java

index faaa7b26306d29cee59a414deb59ce415a0fea3d..7870335dd93481d1edcb0477ce1c89b1748ddecf 100644

--- a/remoting/android/java/src/org/chromium/chromoting/HelpActivity.java

+++ b/remoting/android/java/src/org/chromium/chromoting/HelpActivity.java

@@ -48,7 +48,7 @@ public class HelpActivity extends Activity {

* This global variable is used for passing the screenshot from the originating Activity to the

* HelpActivity. There seems to be no better way of doing this.

- private static Bitmap mScreenshot;

+ private static Bitmap sScreenshot;

/** Constant used to send the feedback parcel to the system feedback service. */

private static final int SEND_FEEDBACK_INFO = Binder.FIRST_CALL_TRANSACTION;

@@ -78,8 +78,8 @@ public class HelpActivity extends Activity {

public void onServiceConnected(ComponentName name, IBinder service) {

try {

Parcel parcel = Parcel.obtain();

- if (mScreenshot != null) {

- mScreenshot.writeToParcel(parcel, 0);

+ if (sScreenshot != null) {

+ sScreenshot.writeToParcel(parcel, 0);

}

service.transact(SEND_FEEDBACK_INFO, parcel, null, 0);

parcel.recycle();

@@ -98,7 +98,7 @@ public class HelpActivity extends Activity {

/** Launches the Help activity. */

public static void launch(Activity activity, String helpUrl) {

View rootView = activity.getWindow().getDecorView().getRootView();

- mScreenshot = UiUtils.generateScaledScreenshot(rootView, MAX_FEEDBACK_SCREENSHOT_DIMENSION,

+ sScreenshot = UiUtils.generateScaledScreenshot(rootView, MAX_FEEDBACK_SCREENSHOT_DIMENSION,

Bitmap.Config.ARGB_8888);

Intent intent = new Intent(activity, HelpActivity.class);