Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateOptionsTest.java

Issue 455523002: [Checkstyle] Update static variable and constant names to match style guides. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: yfriendman's nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateOptionsTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateOptionsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateOptionsTest.java
index 744781045443c91078ac6b7a957815c672b668b5..3e53baa04242b8fbd97e1f280ae49046e579f57b 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateOptionsTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateOptionsTest.java
@@ -14,13 +14,13 @@ import org.chromium.chrome.browser.infobar.TranslateOptions;
* Test for TranslateOptions.
*/
public class TranslateOptionsTest extends AndroidTestCase {
- private static final String[] languages = {"English", "Spanish", "French"};
+ private static final String[] LANGUAGES = {"English", "Spanish", "French"};
private static final boolean ALWAYS_TRANSLATE = true;
@SmallTest
@Feature({"Translate"})
public void testNoChanges() {
- TranslateOptions options = new TranslateOptions(0, 1, languages, ALWAYS_TRANSLATE, false);
+ TranslateOptions options = new TranslateOptions(0, 1, LANGUAGES, ALWAYS_TRANSLATE, false);
assertEquals("English", options.sourceLanguage());
assertEquals("Spanish", options.targetLanguage());
assertEquals(0, options.sourceLanguageIndex());
@@ -34,7 +34,7 @@ public class TranslateOptionsTest extends AndroidTestCase {
@SmallTest
@Feature({"Translate"})
public void testBasicLanguageChanges() {
- TranslateOptions options = new TranslateOptions(0, 1, languages, !ALWAYS_TRANSLATE, true);
+ TranslateOptions options = new TranslateOptions(0, 1, LANGUAGES, !ALWAYS_TRANSLATE, true);
options.setTargetLanguage(2);
options.setSourceLanguage(1);
assertEquals("Spanish", options.sourceLanguage());
@@ -53,7 +53,7 @@ public class TranslateOptionsTest extends AndroidTestCase {
@SmallTest
@Feature({"Translate"})
public void testInvalidLanguageChanges() {
- TranslateOptions options = new TranslateOptions(0, 1, languages, ALWAYS_TRANSLATE, false);
+ TranslateOptions options = new TranslateOptions(0, 1, LANGUAGES, ALWAYS_TRANSLATE, false);
// Same target language as source
assertFalse(options.setTargetLanguage(0));
@@ -75,7 +75,7 @@ public class TranslateOptionsTest extends AndroidTestCase {
@SmallTest
@Feature({"Translate"})
public void testBasicOptionsChanges() {
- TranslateOptions options = new TranslateOptions(0, 1, languages, !ALWAYS_TRANSLATE, false);
+ TranslateOptions options = new TranslateOptions(0, 1, LANGUAGES, !ALWAYS_TRANSLATE, false);
assertFalse(options.optionsChanged());
options.toggleNeverTranslateDomainState(true);
assertTrue(options.neverTranslateDomainState());
@@ -99,7 +99,7 @@ public class TranslateOptionsTest extends AndroidTestCase {
@SmallTest
@Feature({"Translate"})
public void testInvalidOptionsChanges() {
- TranslateOptions options = new TranslateOptions(0, 1, languages, ALWAYS_TRANSLATE, false);
+ TranslateOptions options = new TranslateOptions(0, 1, LANGUAGES, ALWAYS_TRANSLATE, false);
// Never translate language should not work, but never translate domain should
assertFalse(options.toggleNeverTranslateLanguageState(true));

Powered by Google App Engine
This is Rietveld 408576698