Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/InputDialogContainerTest.java

Issue 455523002: [Checkstyle] Update static variable and constant names to match style guides. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: yfriendman's nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/input/InputDialogContainerTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/InputDialogContainerTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/InputDialogContainerTest.java
index 003a92f40a7deccca6214e7fbc49a5f45a0a92f4..aafef355694385f5879b6410b22bda434e2afd67 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/InputDialogContainerTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/InputDialogContainerTest.java
@@ -11,24 +11,24 @@ import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.test.util.Feature;
public class InputDialogContainerTest extends AndroidTestCase {
- private static int TEXT_INPUT_TYPE_DATE = 0;
- private static int TEXT_INPUT_TYPE_DATETIME = 1;
- private static int TEXT_INPUT_TYPE_DATETIMELOCAL = 2;
- private static int TEXT_INPUT_TYPE_MONTH = 3;
- private static int TEXT_INPUT_TYPE_TIME = 4;
- private static int TEXT_INPUT_TYPE_WEEK = 5;
+ private static final int TEXT_INPUT_TYPE_DATE = 0;
+ private static final int TEXT_INPUT_TYPE_DATETIME = 1;
+ private static final int TEXT_INPUT_TYPE_DATETIMELOCAL = 2;
+ private static final int TEXT_INPUT_TYPE_MONTH = 3;
+ private static final int TEXT_INPUT_TYPE_TIME = 4;
+ private static final int TEXT_INPUT_TYPE_WEEK = 5;
// Defined in third_party/WebKit/Source/platform/DateComponents.h
- private static double DATE_DIALOG_DEFAULT_MIN = -62135596800000.0;
- private static double DATE_DIALOG_DEFAULT_MAX = 8640000000000000.0;
- private static double DATETIMELOCAL_DIALOG_DEFAULT_MIN = -62135596800000.0;
- private static double DATETIMELOCAL_DIALOG_DEFAULT_MAX = 8640000000000000.0;
- private static double MONTH_DIALOG_DEFAULT_MIN = -23628.0;
- private static double MONTH_DIALOG_DEFAULT_MAX = 3285488.0;
- private static double TIME_DIALOG_DEFAULT_MIN = 0.0;
- private static double TIME_DIALOG_DEFAULT_MAX = 86399999.0;
- private static double WEEK_DIALOG_DEFAULT_MIN = -62135596800000.0;
- private static double WEEK_DIALOG_DEFAULT_MAX = 8639999568000000.0;
+ private static final double DATE_DIALOG_DEFAULT_MIN = -62135596800000.0;
+ private static final double DATE_DIALOG_DEFAULT_MAX = 8640000000000000.0;
+ private static final double DATETIMELOCAL_DIALOG_DEFAULT_MIN = -62135596800000.0;
+ private static final double DATETIMELOCAL_DIALOG_DEFAULT_MAX = 8640000000000000.0;
+ private static final double MONTH_DIALOG_DEFAULT_MIN = -23628.0;
+ private static final double MONTH_DIALOG_DEFAULT_MAX = 3285488.0;
+ private static final double TIME_DIALOG_DEFAULT_MIN = 0.0;
+ private static final double TIME_DIALOG_DEFAULT_MAX = 86399999.0;
+ private static final double WEEK_DIALOG_DEFAULT_MIN = -62135596800000.0;
+ private static final double WEEK_DIALOG_DEFAULT_MAX = 8639999568000000.0;
InputActionDelegateForTests mInputActionDelegate;
InputDialogContainerForTests mInputDialogContainer;
@@ -332,7 +332,7 @@ public class InputDialogContainerTest extends AndroidTestCase {
@Override
public void cancelDateTimeDialog() {
}
- };
+ }
private static class InputDialogContainerForTests extends InputDialogContainer {
private int mExpectedDialogType;
@@ -391,6 +391,7 @@ public class InputDialogContainerTest extends AndroidTestCase {
assertEquals(mExpectedStep, step);
}
+ @Override
public void setFieldDateTimeValue(int dialogType,
int year, int month, int monthDay,
int hourOfDay, int minute, int second, int millis,

Powered by Google App Engine
This is Rietveld 408576698