Implement support for <extensionoptions> embedding in WebUI

chrome/common/extensions/api/_api_features.json

Index: chrome/common/extensions/api/_api_features.json
diff --git a/chrome/common/extensions/api/_api_features.json b/chrome/common/extensions/api/_api_features.json
index 9e94aa8716f64cf2363440f2eea456d9a37aab92..6892201d6fd6b61cb49b97c8e1dd6a08c08f243a 100644
--- a/chrome/common/extensions/api/_api_features.json
+++ b/chrome/common/extensions/api/_api_features.json
@@ -363,11 +363,16 @@
   "extension.sendRequest": {
     "contexts": ["blessed_extension", "unblessed_extension", "content_script"]
   },
-  "extensionOptionsInternal": {
+  "extensionOptionsInternal": [{
     "internal": true,
     "contexts": ["blessed_extension"],
     "dependencies": ["permission:embeddedExtensionOptions"]
-  },
+  }, {
+    "internal": true,
+    "channel": "trunk",
+    "contexts": ["webui"],
+    "matches": ["chrome://*/*"]

[not at google - send to devlin, 2014/08/07 23:06:02]

can you make this more specific than all of chrome?

[ericzeng, 2014/08/08 00:23:46]

Done, but I'm not sure why this combination in particular makes it work. 

I tried to do the same to guestViewInternal but my test becomes extremely flaky.
Probably due to that bug you were talking about earlier.

[not at google - send to devlin, 2014/08/08 14:08:15]

- the second rule chrome://chrome/extensions should have the wildcard at the
end.
- the third rule shouldn't be necessary since that's covered by the first rule
(chrome-extension:// URLs are blessed extensions... unless they live in iframes)
your test becomes flaky making that change to guestviewinternal? how odd. in
what way? It doesn't sound like the bug I was seeing, since these are all
running in the same context.

[ericzeng, 2014/08/08 21:35:51]

I think I fixed it actually, it was easier to find out which matches I need
using Feature

+  }],
   // This is not a real API, only here for documentation purposes.
   // See http://crbug.com/275944 for background.
   "extensionsManifestTypes": {
@@ -441,6 +446,11 @@
     "internal": true,
     "dependencies": ["permission:webview"],
     "contexts": ["unblessed_extension"]
+  }, {
+    "internal": true,
+    "channel": "trunk",
+    "contexts": ["webui"],
+    "matches": ["chrome://*/*"]
   }],

[not at google - send to devlin, 2014/08/07 23:06:02]

ideally this API rule would actually be:

"guestViewInternal": [{
  "internal": true,
  "dependencies": ["api:appViewInternal"]
}, {
  "internal": true,
  "dependencies": ["api:extensionOptionsInternal"]
}, {
  "internal": true,
  "dependencies": ["api:webViewInternal"]
}]

curious whether that passes all the tests. in fact, I'm going to try it now. I
wouldn't try making it work yourself, though, what you have is fine for now.

[ericzeng, 2014/08/08 00:23:46]

Acknowledged.

   "hangoutsPrivate": {
     "channel": "stable",