Implement support for <extensionoptions> embedding in WebUI

chrome/renderer/chrome_content_renderer_client.cc

Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index d2a85a59fc0b156f0dd142ea6967843f8ed51c3b..8c43ada0dc6ad421e0de69ae1be28ccd00a08956 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -513,6 +513,14 @@ const Extension* ChromeContentRendererClient::GetExtensionByOrigin(
   return extension_dispatcher_->extensions()->GetByID(extension_id);
 }
 
+void GetScriptContextForGuestView(extensions::ScriptContext** out,

[not at google - send to devlin, 2014/08/07 23:06:03]

should be in an anonymous namespace.

and "Find" might be a better term?

[ericzeng, 2014/08/08 00:23:47]

Done.

+                                  extensions::ScriptContext* in) {
+  if (in->context_type() == extensions::Feature::BLESSED_EXTENSION_CONTEXT ||
+      in->context_type() == extensions::Feature::WEBUI_CONTEXT) {
+    *out = in;
+  }
+}
+
 bool ChromeContentRendererClient::OverrideCreatePlugin(
     content::RenderFrame* render_frame,
     WebLocalFrame* frame,
@@ -520,18 +528,18 @@ bool ChromeContentRendererClient::OverrideCreatePlugin(
     WebPlugin** plugin) {
   std::string orig_mime_type = params.mimeType.utf8();
   if (orig_mime_type == content::kBrowserPluginMimeType) {
-    WebDocument document = frame->document();
-    const Extension* extension =
-        GetExtensionByOrigin(document.securityOrigin());
-    if (extension) {
-      const extensions::APIPermission::ID perms[] = {
-          extensions::APIPermission::kAppView,
-          extensions::APIPermission::kEmbeddedExtensionOptions,
-          extensions::APIPermission::kWebView,
-      };
-      for (size_t i = 0; i < arraysize(perms); ++i) {
-        if (extension->permissions_data()->HasAPIPermission(perms[i]))
-          return false;
+    // See chrome/common/extensions/api/_api_features.json for API names
+    const std::string perms[] = {"appViewInternal", "extensionOptionsInternal",
+                                 "webViewInternal"};

[not at google - send to devlin, 2014/08/07 23:06:03]

hm, in https://codereview.chromium.org/426593007/ I add constants for these. we
should really keep them in sync, but I'm not sure how - there doesn't appear to
be any shared files between the browser and renderer relating to guestview.

fady?

[Fady Samuel, 2014/08/07 23:14:01]

Nope, perhaps something in chrome/common/guest_view?

+
+    extensions::ScriptContext* context = NULL;
+    extension_dispatcher_->script_context_set().ForEach(
+        render_frame->GetRenderView(),
+        base::Bind(&GetScriptContextForGuestView, &context));

[Fady Samuel, 2014/08/07 23:09:29]

If I'm reading this correctly, context will be NULL if it's neither extension
nor WebUI, right? Then we access it below? May we don't need this perm check at
all here? The browser process will not allow the creation of guests of these
types without the appropriate permission anyway. Do we need an extra check in
the renderer?

[ericzeng, 2014/08/08 00:23:47]

Fixed the null pointer issue - see kalman's comment below.

It looks like we need an early escape from the code below in order to create the
guest view browser plugin. If not, I think this method just creates some kind of
web plugin, and never creates a BrowserPlugin in RenderFrameImpl. 
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/r...

+

[not at google - send to devlin, 2014/08/07 23:06:03]

you need to check whether it actually found a context.

though really a better check would be to instead of finding an appropriate
script context, to just look through them and see if any have the guestview API
available.

and for *that* - I suppose you could have all of these constants here. but even
easier would to just check for the availability of the guestViewInternal API.

that sort of thing would be:

FindScriptContextWithGuestView(bool* found, ScriptContext* context) {
  if (context->GetAvailability("guestViewInternal").is_available())
    *found = true;
}

...

bool found = true;
extension_dispatcher_->script_context_set().ForEach(
  render_frame->GetRenderView(),
  base::Bind(&FindScriptContextWithGuestView, &found));
if (found)
  return false;

[ericzeng, 2014/08/08 00:23:47]

Done.

+    for (size_t i = 0; i < arraysize(perms); ++i) {
+      if (context->GetAvailability(perms[i]).is_available()) {
+        return false;
       }
     }
   }
@@ -591,7 +599,6 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
   GURL url(original_params.url);
   std::string orig_mime_type = original_params.mimeType.utf8();
   ChromePluginPlaceholder* placeholder = NULL;
-

[not at google - send to devlin, 2014/08/07 23:06:03]

probably should revert this change.

[ericzeng, 2014/08/08 00:23:47]

Done.

   // If the browser plugin is to be enabled, this should be handled by the
   // renderer, so the code won't reach here due to the early exit in
   // OverrideCreatePlugin.