Implement support for <extensionoptions> embedding in WebUI

chrome/common/extensions/api/_api_features.json

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This features file defines extension APIs implemented under src/chrome.
 // See extensions/common/features/* to understand this file, in particular
 // feature.h, simple_feature.h, and base_feature_provider.h.
 //
 // Note that specifying "web_page", "blessed_web_page", or "all" as a context
 // type will require manually updating chrome/renderer/resources/dispatcher.cc.
@@ skipping 345 matching lines @@
   },
   "extension.onRequest": {
     "contexts": ["blessed_extension", "unblessed_extension", "content_script"]
   },
   "extension.sendNativeMessage": {
     "dependencies": ["permission:nativeMessaging"]
   },
   "extension.sendRequest": {
     "contexts": ["blessed_extension", "unblessed_extension", "content_script"]
   },
-  "extensionOptionsInternal": {
+  "extensionOptionsInternal": [{
     "internal": true,
     "contexts": ["blessed_extension"],
     "dependencies": ["permission:embeddedExtensionOptions"]
-  },
+  }, {
+    "internal": true,
+    "channel": "trunk",
+    "contexts": ["webui"],
+    "matches": ["chrome://*/*"]

[not at google - send to devlin, 2014/08/07 23:06:02]

can you make this more specific than all of chrome?

[ericzeng, 2014/08/08 00:23:46]

Done, but I'm not sure why this combination in particular makes it work. 

I tried to do the same to guestViewInternal but my test becomes extremely flaky.
Probably due to that bug you were talking about earlier.

[not at google - send to devlin, 2014/08/08 14:08:15]

- the second rule chrome://chrome/extensions should have the wildcard at the
end.
- the third rule shouldn't be necessary since that's covered by the first rule
(chrome-extension:// URLs are blessed extensions... unless they live in iframes)
your test becomes flaky making that change to guestviewinternal? how odd. in
what way? It doesn't sound like the bug I was seeing, since these are all
running in the same context.

[ericzeng, 2014/08/08 21:35:51]

I think I fixed it actually, it was easier to find out which matches I need
using Feature

+  }],
   // This is not a real API, only here for documentation purposes.
   // See http://crbug.com/275944 for background.
   "extensionsManifestTypes": {
     "internal": true,
     "channel": "stable",
     "contexts": ["blessed_extension"]
   },
   "feedbackPrivate": {
     "dependencies": ["permission:feedbackPrivate"],
     "contexts": ["blessed_extension"]
@@ skipping 53 matching lines @@
   "guestViewInternal": [{
     "internal": true,
     "channel": "stable",
     "contexts": ["blessed_extension"]
   }, {
     // Component extensions can use the guestViewInternal API from iframes.
     "location": "component",
     "internal": true,
     "dependencies": ["permission:webview"],
     "contexts": ["unblessed_extension"]
+  }, {
+    "internal": true,
+    "channel": "trunk",
+    "contexts": ["webui"],
+    "matches": ["chrome://*/*"]
   }],

[not at google - send to devlin, 2014/08/07 23:06:02]

ideally this API rule would actually be:

"guestViewInternal": [{
  "internal": true,
  "dependencies": ["api:appViewInternal"]
}, {
  "internal": true,
  "dependencies": ["api:extensionOptionsInternal"]
}, {
  "internal": true,
  "dependencies": ["api:webViewInternal"]
}]

curious whether that passes all the tests. in fact, I'm going to try it now. I
wouldn't try making it work yourself, though, what you have is fine for now.

[ericzeng, 2014/08/08 00:23:46]

Acknowledged.

   "hangoutsPrivate": {
     "channel": "stable",
     "contexts": ["blessed_extension"],
     "whitelist": [
       // http://crbug.com/309737
       "nckgahadagoaajjgafhacjanaoiihapd",
       "ljclpkphhpbpinifbeabbhlfddcpfdde",
       "ppleadejekpmccmnpjdimmlfljlkdfej",
       "eggnbpckecmjlblplehfpjjdhhidfdoj",
       "jfjjdfefebklmdbmenmlehlopoocnoeh",
@@ skipping 351 matching lines @@
     "internal": true,
     "channel": "stable",
     "dependencies": ["permission:webview"],
     "contexts": ["blessed_extension"]
   },
   "windows": {
     "dependencies": ["api:tabs"],
     "contexts": ["blessed_extension"]
   }
 }