Implement support for <extensionoptions> embedding in WebUI

chrome/browser/guest_view/guest_view_base.cc

Index: chrome/browser/guest_view/guest_view_base.cc
diff --git a/chrome/browser/guest_view/guest_view_base.cc b/chrome/browser/guest_view/guest_view_base.cc
index 1300cfbb50d4b30240729963b6c2ff87dfcf8b4a..0c0480fa7fad2babc06ba90cefc24b832a30878f 100644
--- a/chrome/browser/guest_view/guest_view_base.cc
+++ b/chrome/browser/guest_view/guest_view_base.cc
@@ -106,9 +106,11 @@ void GuestViewBase::Init(
     return;
   initialized_ = true;
 
-  if (!CanEmbedderUseGuestView(embedder_extension_id)) {
-    callback.Run(NULL);
-    return;
+  if (!embedder_extension_id.empty()) {

[not at google - send to devlin, 2014/08/07 23:06:02]

this should also be unnecessary

[ericzeng, 2014/08/08 00:23:46]

I'll leave it in until your patch lands.

[not at google - send to devlin, 2014/08/08 14:08:15]

stay tuned!

+    if (!CanEmbedderUseGuestView(embedder_extension_id)) {
+      callback.Run(NULL);
+      return;
+    }
   }
 
   CreateWebContents(embedder_extension_id,
@@ -389,10 +391,6 @@ GuestViewBase::~GuestViewBase() {
 
 void GuestViewBase::DispatchEventToEmbedder(Event* event) {
   scoped_ptr<Event> event_ptr(event);
-  if (!in_extension()) {
-    NOTREACHED();
-    return;
-  }
 

[not at google - send to devlin, 2014/08/07 23:06:02]

but you'll still need this. it's not an important check because the event router
makes it anyway.

[Fady Samuel, 2014/08/07 23:09:29]

Will the event router work in WebUI? Will WebUI receive extension events?

[not at google - send to devlin, 2014/08/07 23:13:54]

yes, this is one of the things I made work.

however I didn't make filtered events work.

[ericzeng, 2014/08/08 00:23:46]

What do you mean by I'll still need it? Won't it crash every time I try to embed
extensionoptions outside of an extension?

[not at google - send to devlin, 2014/08/08 14:08:15]

I meant you'll still need to make this change :) bad wording sorry.

   if (!attached()) {
     pending_events_.push_back(linked_ptr<Event>(event_ptr.release()));