Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 452613002: [Checkstyle] Update class member variable names to match style guides. (Closed)

Created:
6 years, 4 months ago by aurimas (slooooooooow)
Modified:
6 years, 4 months ago
Reviewers:
Yaron, boliu, newt (away)
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, riju_, benquan, jam, ilevy-cc_chromium.org, browser-components-watch_chromium.org, timvolodine, haitaol+watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, Michael van Ouwerkerk, yfriedman+watch_chromium.org, estade+watch_chromium.org, klundberg+watch_chromium.org, Ilya Sherman, android-webview-reviews_chromium.org, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Checkstyle] Update class member variable names to match style guides. - Non-public, non-static field names start with m. http://source.android.com/source/code-style.html#follow-field-naming-conventions BUG=318404 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288299

Patch Set 1 #

Total comments: 2

Patch Set 2 : boliu nits #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -158 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/ClientCertLookupTable.java View 1 chunk +5 lines, -5 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenVideoTest.java View 2 chunks +10 lines, -10 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java View 1 2 chunks +4 lines, -4 lines 1 comment Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java View 1 chunk +1 line, -1 line 1 comment Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java View 1 chunk +11 lines, -11 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageStartedTest.java View 1 chunk +13 lines, -12 lines 0 comments Download
M android_webview/unittestjava/src/org/chromium/android_webview/unittest/InputStreamUnittest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java View 5 chunks +30 lines, -30 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ShortcutHelperTest.java View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/DeviceSensorsTest.java View 11 chunks +35 lines, -35 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/MediaResourceGetterTest.java View 11 chunks +13 lines, -13 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java View 6 chunks +8 lines, -8 lines 0 comments Download
M tools/android/checkstyle/chromium-style-5.0.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
aurimas (slooooooooow)
boliu@chromium.org: Please review changes in android_webview. yfriedman@chromium.org: Please review changes in the rest of the ...
6 years, 4 months ago (2014-08-07 22:17:07 UTC) #1
boliu
https://codereview.chromium.org/452613002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java (left): https://codereview.chromium.org/452613002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java#oldcode11 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java:11: import org.chromium.android_webview.AwContentsClient.ShouldInterceptRequestParams; This looks like it's required?
6 years, 4 months ago (2014-08-07 22:26:22 UTC) #2
Yaron
lgtm
6 years, 4 months ago (2014-08-07 23:27:15 UTC) #3
aurimas (slooooooooow)
https://codereview.chromium.org/452613002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java (left): https://codereview.chromium.org/452613002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java#oldcode11 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java:11: import org.chromium.android_webview.AwContentsClient.ShouldInterceptRequestParams; On 2014/08/07 22:26:22, boliu wrote: > This ...
6 years, 4 months ago (2014-08-08 01:44:18 UTC) #4
boliu
lgtm
6 years, 4 months ago (2014-08-08 01:51:03 UTC) #5
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 4 months ago (2014-08-08 01:58:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/452613002/20001
6 years, 4 months ago (2014-08-08 02:05:42 UTC) #7
commit-bot: I haz the power
Change committed as 288299
6 years, 4 months ago (2014-08-08 10:09:49 UTC) #8
newt (away)
6 years, 4 months ago (2014-08-08 16:01:29 UTC) #9
Message was sent while issue was closed. 
two nits

https://codereview.chromium.org/452613002/diff/20001/android_webview/javatest...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java
(right):

https://codereview.chromium.org/452613002/diff/20001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java:121:
private static final String TEAPOD_RESPONSE_PHRASE = "I'm a teapot";
s/TEAPOD/TEAPOT

https://codereview.chromium.org/452613002/diff/20001/android_webview/javatest...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java
(right):

https://codereview.chromium.org/452613002/diff/20001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java:27:
private static float MAXIMUM_SCALE = 2.0f;
add "final". The current way this is written should cause checkstyle to fail,
right?

Powered by Google App Engine
This is Rietveld 408576698