android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java - Issue 452613002: [Checkstyle] Update class member variable names to match style guides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

Issue 452613002: [Checkstyle] Update class member variable names to match style guides. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: boliu nits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java ('k') | android_webview/java/src/org/chromium/android_webview/ClientCertLookupTable.java » ('j') | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

index 70a148b57f904c83ff95dc63ee7612cec82202ff..85466cecd6db88d9d7b636ba107591430121121e 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

@@ -171,13 +171,13 @@ class AwWebContentsDelegateAdapter extends AwWebContentsDelegate {

params.capture = capture;

mContentsClient.showFileChooser(new ValueCallback<String[]>() {

- boolean completed = false;

+ boolean mCompleted = false;

@Override

public void onReceiveValue(String[] results) {

- if (completed) {

+ if (mCompleted) {

throw new IllegalStateException("Duplicate showFileChooser result");

}

- completed = true;

+ mCompleted = true;

nativeFilesSelectedInChooser(processId, renderId, mode_flags, results);

}

}, params);