android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java - Issue 452613002: [Checkstyle] Update class member variable names to match style guides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

Issue 452613002: [Checkstyle] Update class member variable names to match style guides. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: boliu nits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenVideoTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java » ('j') | android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

index de8e625172ba8af2e4378988897cdff843a58210..0402f4c3f052a5985aa66554209b3f1d0356d60b 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java

@@ -117,8 +117,8 @@ public class AwContentsClientShouldInterceptRequestTest extends AwTestBase {

}

- final int teapotStatusCode = 418;

- final String teapotResponsePhrase = "I'm a teapot";

+ private static final int TEAPOT_STATUS_CODE = 418;

+ private static final String TEAPOD_RESPONSE_PHRASE = "I'm a teapot";

newt (away) 2014/08/08 16:01:29 s/TEAPOD/TEAPOT

private String addPageToTestServer(TestWebServer webServer, String httpPath, String html) {

List<Pair<String, String>> headers = new ArrayList<Pair<String, String>>();

@@ -492,8 +492,8 @@ public class AwContentsClientShouldInterceptRequestTest extends AwTestBase {

mShouldInterceptRequestHelper.setReturnValue(

new AwWebResourceResponse("text/html", "UTF-8", new EmptyInputStream(),

- teapotStatusCode, teapotResponsePhrase, new HashMap<String, String>()));

- assertEquals("\"[" + teapotStatusCode + "][" + teapotResponsePhrase + "]\"",

+ TEAPOT_STATUS_CODE, TEAPOD_RESPONSE_PHRASE, new HashMap<String, String>()));

+ assertEquals("\"[" + TEAPOT_STATUS_CODE + "][" + TEAPOD_RESPONSE_PHRASE + "]\"",

executeJavaScriptAndWaitForResult(mAwContents, mContentsClient, syncGetJs));

}