android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java - Issue 452613002: [Checkstyle] Update class member variable names to match style guides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java

Issue 452613002: [Checkstyle] Update class member variable names to match style guides. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: boliu nits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/ClientCertLookupTable.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenVideoTest.java » ('j') | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java

index 3ada155c7f510ca20844689492b6f45d76fad46e..a7fdde96d36b3b5b2ac66796634cdbfe81a80cc6 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java

@@ -23,7 +23,7 @@ import java.util.concurrent.atomic.AtomicReference;

* Tests for certain edge cases related to integrating with the Android view system.

public class AndroidViewIntegrationTest extends AwTestBase {

- final int CONTENT_SIZE_CHANGE_STABILITY_TIMEOUT_MS = 1000;

+ private static final int CONTENT_SIZE_CHANGE_STABILITY_TIMEOUT_MS = 1000;

private static class OnContentSizeChangedHelper extends CallbackHelper {

private int mWidth;

@@ -76,7 +76,7 @@ public class AndroidViewIntegrationTest extends AwTestBase {

};

}

- final LinearLayout.LayoutParams wrapContentLayoutParams =

+ final LinearLayout.LayoutParams mWrapContentLayoutParams =

new LinearLayout.LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.WRAP_CONTENT);

private AwTestContainerView createCustomTestContainerViewOnMainSync(

@@ -87,7 +87,7 @@ public class AndroidViewIntegrationTest extends AwTestBase {

@Override

public void run() {

testContainerView.set(createAwTestContainerView(awContentsClient));

- testContainerView.get().setLayoutParams(wrapContentLayoutParams);

+ testContainerView.get().setLayoutParams(mWrapContentLayoutParams);

testContainerView.get().setVisibility(visibility);

}

});