Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 449943002: Move t.p.PageMeasurementUnitTestBase to t.testing.PageTestTestCase. (Closed)

Created:
6 years, 4 months ago by chrishenry
Modified:
6 years, 4 months ago
Reviewers:
nednguyen, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tic_kill_perf_page_measurement
Project:
chromium
Visibility:
Public.

Description

Move t.p.PageMeasurementUnitTestBase to t.testing.PageTestTestCase. (PageTestTestCase should also be the place to merge the unit test helper defined in TestPageTestResults.) BUG=383635 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288182

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -143 lines) Patch
M tools/perf/measurements/loading_trace_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro_unittest.py View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/perf/measurements/record_per_area_unittest.py View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/perf/measurements/repaint_unittest.py View 2 chunks +2 lines, -3 lines 0 comments Download
M tools/perf/measurements/screenshot_unittest.py View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/perf/measurements/skpicture_printer_unittest.py View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 2 chunks +2 lines, -3 lines 0 comments Download
M tools/perf/measurements/thread_times_unittest.py View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/page_measurement_unittest.py View 2 chunks +2 lines, -3 lines 0 comments Download
D tools/telemetry/telemetry/page/page_measurement_unittest_base.py View 1 chunk +0 lines, -109 lines 0 comments Download
A + tools/telemetry/telemetry/testing/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/testing/page_test_test_case.py View 2 chunks +5 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
chrishenry
6 years, 4 months ago (2014-08-07 18:16:20 UTC) #1
tonyg
lgtm
6 years, 4 months ago (2014-08-07 19:18:58 UTC) #2
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 4 months ago (2014-08-07 19:21:42 UTC) #3
nednguyen
lgtm
6 years, 4 months ago (2014-08-07 19:23:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/449943002/20001
6 years, 4 months ago (2014-08-07 19:27:30 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 00:52:39 UTC) #6
Message was sent while issue was closed.
Change committed as 288182

Powered by Google App Engine
This is Rietveld 408576698