Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: tools/telemetry/telemetry/testing/page_test_test_case.py

Issue 449943002: Move t.p.PageMeasurementUnitTestBase to t.testing.PageTestTestCase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tic_kill_perf_page_measurement
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/testing/page_test_test_case.py
diff --git a/tools/telemetry/telemetry/page/page_measurement_unittest_base.py b/tools/telemetry/telemetry/testing/page_test_test_case.py
similarity index 95%
rename from tools/telemetry/telemetry/page/page_measurement_unittest_base.py
rename to tools/telemetry/telemetry/testing/page_test_test_case.py
index 28346a485fc9d8e73d15ce295af164cfd35e2961..3d25d66b3879a35c6770364bed911f6a95a3ec6b 100644
--- a/tools/telemetry/telemetry/page/page_measurement_unittest_base.py
+++ b/tools/telemetry/telemetry/testing/page_test_test_case.py
@@ -2,6 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+"""Provide a TestCase base class for PageTest subclasses' unittests."""
+
import unittest
from telemetry import benchmark
@@ -31,9 +33,9 @@ class EmptyMetadataForTest(benchmark.BenchmarkMetadata):
def __init__(self):
super(EmptyMetadataForTest, self).__init__('')
-class PageMeasurementUnitTestBase(unittest.TestCase):
- """unittest.TestCase-derived class to help in the construction of unit tests
- for a measurement."""
+
+class PageTestTestCase(unittest.TestCase):
+ """A base class to simplify writing unit tests for PageTest subclasses."""
def CreatePageSetFromFileInUnittestDataDir(self, test_filename):
ps = self.CreateEmptyPageSet()

Powered by Google App Engine
This is Rietveld 408576698