tools/telemetry/telemetry/page/page_measurement_unittest.py - Issue 449943002: Move t.p.PageMeasurementUnitTestBase to t.testing.PageTestTestCase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_measurement_unittest.py

Issue 449943002: Move t.p.PageMeasurementUnitTestBase to t.testing.PageTestTestCase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tic_kill_perf_page_measurement

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/measurements/thread_times_unittest.py ('k') | tools/telemetry/telemetry/page/page_measurement_unittest_base.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/page_measurement_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_measurement_unittest.py b/tools/telemetry/telemetry/page/page_measurement_unittest.py

index 55b18083226015c9e76a0ac76e3f388e359812c1..9dddc85004c7e6365caa63e7ba2585318c96aeb4 100644

--- a/tools/telemetry/telemetry/page/page_measurement_unittest.py

+++ b/tools/telemetry/telemetry/page/page_measurement_unittest.py

@@ -9,10 +9,10 @@ from telemetry import benchmark

from telemetry.core import exceptions

from telemetry.core import wpr_modes

from telemetry.page import page as page_module

-from telemetry.page import page_measurement_unittest_base

from telemetry.page import page_set

from telemetry.page import page_set_archive_info

from telemetry.page import page_test

+from telemetry.testing import page_test_test_case

from telemetry.unittest import options_for_unittests

from telemetry.value import scalar

@@ -70,8 +70,7 @@ class PageWithAction(page_module.Page):

def RunTestAction(self, _):

self.run_test_action_called = True

-class PageMeasurementUnitTest(

- page_measurement_unittest_base.PageMeasurementUnitTestBase):

+class PageMeasurementUnitTest(page_test_test_case.PageTestTestCase):

def setUp(self):

self._options = options_for_unittests.GetCopy()