Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: tools/telemetry/telemetry/page/page_measurement_unittest_base.py

Issue 449943002: Move t.p.PageMeasurementUnitTestBase to t.testing.PageTestTestCase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tic_kill_perf_page_measurement
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_measurement_unittest_base.py
diff --git a/tools/telemetry/telemetry/page/page_measurement_unittest_base.py b/tools/telemetry/telemetry/page/page_measurement_unittest_base.py
deleted file mode 100644
index 28346a485fc9d8e73d15ce295af164cfd35e2961..0000000000000000000000000000000000000000
--- a/tools/telemetry/telemetry/page/page_measurement_unittest_base.py
+++ /dev/null
@@ -1,109 +0,0 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import unittest
-
-from telemetry import benchmark
-from telemetry.core import exceptions
-from telemetry.core import util
-from telemetry.page import page_runner
-from telemetry.page import page as page_module
-from telemetry.page import page_set as page_set_module
-from telemetry.page import page_test
-from telemetry.results import results_options
-from telemetry.page import test_expectations
-from telemetry.unittest import options_for_unittests
-
-
-class BasicTestPage(page_module.Page):
- def __init__(self, url, page_set, base_dir):
- super(BasicTestPage, self).__init__(url, page_set, base_dir)
-
- def RunSmoothness(self, action_runner):
- interaction = action_runner.BeginGestureInteraction(
- 'ScrollAction', is_smooth=True)
- action_runner.ScrollPage()
- interaction.End()
-
-
-class EmptyMetadataForTest(benchmark.BenchmarkMetadata):
- def __init__(self):
- super(EmptyMetadataForTest, self).__init__('')
-
-class PageMeasurementUnitTestBase(unittest.TestCase):
- """unittest.TestCase-derived class to help in the construction of unit tests
- for a measurement."""
-
- def CreatePageSetFromFileInUnittestDataDir(self, test_filename):
- ps = self.CreateEmptyPageSet()
- page = BasicTestPage('file://' + test_filename, ps, base_dir=ps.base_dir)
- ps.AddPage(page)
- return ps
-
- def CreateEmptyPageSet(self):
- base_dir = util.GetUnittestDataDir()
- ps = page_set_module.PageSet(file_path=base_dir)
- return ps
-
- def RunMeasurement(self, measurement, ps,
- expectations=test_expectations.TestExpectations(),
- options=None):
- """Runs a measurement against a pageset, returning the rows its outputs."""
- if options is None:
- options = options_for_unittests.GetCopy()
- assert options
- temp_parser = options.CreateParser()
- page_runner.AddCommandLineArgs(temp_parser)
- measurement.AddCommandLineArgs(temp_parser)
- measurement.SetArgumentDefaults(temp_parser)
- defaults = temp_parser.get_default_values()
- for k, v in defaults.__dict__.items():
- if hasattr(options, k):
- continue
- setattr(options, k, v)
-
- measurement.CustomizeBrowserOptions(options.browser_options)
- options.output_file = None
- options.output_format = 'none'
- options.suppress_gtest_report = True
- options.output_trace_tag = None
- page_runner.ProcessCommandLineArgs(temp_parser, options)
- measurement.ProcessCommandLineArgs(temp_parser, options)
- results = results_options.CreateResults(EmptyMetadataForTest(), options)
- page_runner.Run(measurement, ps, expectations, options, results)
- return results
-
- def TestTracingCleanedUp(self, measurement_class, options=None):
- ps = self.CreatePageSetFromFileInUnittestDataDir('blank.html')
- start_tracing_called = [False]
- stop_tracing_called = [False]
-
- class BuggyMeasurement(measurement_class):
- def __init__(self, *args, **kwargs):
- measurement_class.__init__(self, *args, **kwargs)
-
- # Inject fake tracing methods to browser
- def TabForPage(self, page, browser):
- ActualStartTracing = browser.StartTracing
- def FakeStartTracing(*args, **kwargs):
- ActualStartTracing(*args, **kwargs)
- start_tracing_called[0] = True
- raise exceptions.IntentionalException
- browser.StartTracing = FakeStartTracing
-
- ActualStopTracing = browser.StopTracing
- def FakeStopTracing(*args, **kwargs):
- ActualStopTracing(*args, **kwargs)
- stop_tracing_called[0] = True
- browser.StopTracing = FakeStopTracing
-
- return measurement_class.TabForPage(self, page, browser)
-
- measurement = BuggyMeasurement()
- try:
- self.RunMeasurement(measurement, ps, options=options)
- except page_test.TestNotSupportedOnPlatformFailure:
- pass
- if start_tracing_called[0]:
- self.assertTrue(stop_tracing_called[0])
« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement_unittest.py ('k') | tools/telemetry/telemetry/testing/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698