Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 449323002: Revert 288017 "Parse Drive API responses all at once in the bloc..." (Closed)

Created:
6 years, 4 months ago by kinaba
Modified:
6 years, 4 months ago
Reviewers:
kinaba
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 288017 "Parse Drive API responses all at once in the bloc..." It broke Drive sync completely. > Parse Drive API responses all at once in the blocking pool. > > Previous implementation did the parsing of string to base::Value > on blocking pool, and that of base::Value to specific data types > either on UI thread or on yet another post to blocking pool. > > The previous implementation is slightly inefficient and moreover > involves a subtle bug 284244. > > BUG=284244 > > Review URL: https://codereview.chromium.org/442193002 TBR=kinaba@chromium.org BUG=401843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -234 lines) Patch
M trunk/src/chrome/browser/drive/drive_api_service.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/drive/drive_api_util.h View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/drive/drive_api_util.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M trunk/src/google_apis/drive/base_requests.h View 3 chunks +49 lines, -2 lines 0 comments Download
M trunk/src/google_apis/drive/base_requests.cc View 5 chunks +93 lines, -40 lines 0 comments Download
M trunk/src/google_apis/drive/base_requests_unittest.cc View 4 chunks +67 lines, -2 lines 0 comments Download
M trunk/src/google_apis/drive/drive_api_requests.h View 15 chunks +21 lines, -89 lines 0 comments Download
M trunk/src/google_apis/drive/drive_api_requests.cc View 15 chunks +115 lines, -17 lines 0 comments Download
M trunk/src/google_apis/drive/gdata_wapi_requests.h View 1 chunk +4 lines, -19 lines 0 comments Download
M trunk/src/google_apis/drive/gdata_wapi_requests.cc View 2 chunks +4 lines, -50 lines 0 comments Download
M trunk/src/google_apis/drive/gdata_wapi_requests_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kinaba
6 years, 4 months ago (2014-08-08 03:38:01 UTC) #1
kinaba
6 years, 4 months ago (2014-08-08 03:38:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r288216 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698