Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: trunk/src/chrome/browser/drive/drive_api_service.cc

Issue 449323002: Revert 288017 "Parse Drive API responses all at once in the bloc..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/chrome/browser/drive/drive_api_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/drive/drive_api_service.cc
===================================================================
--- trunk/src/chrome/browser/drive/drive_api_service.cc (revision 288215)
+++ trunk/src/chrome/browser/drive/drive_api_service.cc (working copy)
@@ -8,7 +8,10 @@
#include <vector>
#include "base/bind.h"
+#include "base/sequenced_task_runner.h"
#include "base/strings/stringprintf.h"
+#include "base/task_runner_util.h"
+#include "base/values.h"
#include "chrome/browser/drive/drive_api_util.h"
#include "content/public/browser/browser_thread.h"
#include "google_apis/drive/auth_service.h"
@@ -146,16 +149,6 @@
callback.Run(GDATA_OTHER_ERROR, GURL());
}
-void ExtractShareUrlAndRun(const google_apis::GetShareUrlCallback& callback,
- google_apis::GDataErrorCode error,
- scoped_ptr<google_apis::ResourceEntry> entry) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
-
- const google_apis::Link* share_link =
- entry ? entry->GetLinkByType(google_apis::Link::LINK_SHARE) : NULL;
- callback.Run(error, share_link ? share_link->href() : GURL());
-}
-
// Ignores the |entry|, and runs the |callback|.
void EntryActionCallbackAdapter(
const EntryActionCallback& callback,
@@ -383,7 +376,7 @@
wapi_url_generator_,
resource_id,
embed_origin,
- base::Bind(&ExtractShareUrlAndRun,
+ base::Bind(&util::ParseShareUrlAndRun,
callback)));
}
« no previous file with comments | « no previous file | trunk/src/chrome/browser/drive/drive_api_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698