Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: trunk/src/google_apis/drive/gdata_wapi_requests_unittest.cc

Issue 449323002: Revert 288017 "Parse Drive API responses all at once in the bloc..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « trunk/src/google_apis/drive/gdata_wapi_requests.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/message_loop/message_loop.h" 6 #include "base/message_loop/message_loop.h"
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "base/values.h"
8 #include "google_apis/drive/dummy_auth_service.h" 9 #include "google_apis/drive/dummy_auth_service.h"
9 #include "google_apis/drive/gdata_wapi_parser.h" 10 #include "google_apis/drive/gdata_wapi_parser.h"
10 #include "google_apis/drive/gdata_wapi_requests.h" 11 #include "google_apis/drive/gdata_wapi_requests.h"
11 #include "google_apis/drive/gdata_wapi_url_generator.h" 12 #include "google_apis/drive/gdata_wapi_url_generator.h"
12 #include "google_apis/drive/request_sender.h" 13 #include "google_apis/drive/request_sender.h"
13 #include "google_apis/drive/test_util.h" 14 #include "google_apis/drive/test_util.h"
14 #include "net/base/escape.h" 15 #include "net/base/escape.h"
15 #include "net/test/embedded_test_server/embedded_test_server.h" 16 #include "net/test/embedded_test_server/embedded_test_server.h"
16 #include "net/test/embedded_test_server/http_request.h" 17 #include "net/test/embedded_test_server/http_request.h"
17 #include "net/test/embedded_test_server/http_response.h" 18 #include "net/test/embedded_test_server/http_response.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 // The incoming HTTP request is saved so tests can verify the request 92 // The incoming HTTP request is saved so tests can verify the request
92 // parameters like HTTP method (ex. some requests should use DELETE 93 // parameters like HTTP method (ex. some requests should use DELETE
93 // instead of GET). 94 // instead of GET).
94 net::test_server::HttpRequest http_request_; 95 net::test_server::HttpRequest http_request_;
95 }; 96 };
96 97
97 } // namespace 98 } // namespace
98 99
99 TEST_F(GDataWapiRequestsTest, GetResourceEntryRequest_ValidResourceId) { 100 TEST_F(GDataWapiRequestsTest, GetResourceEntryRequest_ValidResourceId) {
100 GDataErrorCode result_code = GDATA_OTHER_ERROR; 101 GDataErrorCode result_code = GDATA_OTHER_ERROR;
101 scoped_ptr<ResourceEntry> result_data; 102 scoped_ptr<base::Value> result_data;
102 103
103 { 104 {
104 base::RunLoop run_loop; 105 base::RunLoop run_loop;
105 GetResourceEntryRequest* request = new GetResourceEntryRequest( 106 GetResourceEntryRequest* request = new GetResourceEntryRequest(
106 request_sender_.get(), 107 request_sender_.get(),
107 *url_generator_, 108 *url_generator_,
108 "file:2_file_resource_id", // resource ID 109 "file:2_file_resource_id", // resource ID
109 GURL(), // embed origin 110 GURL(), // embed origin
110 test_util::CreateQuitCallback( 111 test_util::CreateQuitCallback(
111 &run_loop, 112 &run_loop,
112 test_util::CreateCopyResultCallback(&result_code, &result_data))); 113 test_util::CreateCopyResultCallback(&result_code, &result_data)));
113 request_sender_->StartRequestWithRetry(request); 114 request_sender_->StartRequestWithRetry(request);
114 run_loop.Run(); 115 run_loop.Run();
115 } 116 }
116 117
117 EXPECT_EQ(HTTP_SUCCESS, result_code); 118 EXPECT_EQ(HTTP_SUCCESS, result_code);
118 EXPECT_EQ(net::test_server::METHOD_GET, http_request_.method); 119 EXPECT_EQ(net::test_server::METHOD_GET, http_request_.method);
119 EXPECT_EQ("/feeds/default/private/full/file%3A2_file_resource_id" 120 EXPECT_EQ("/feeds/default/private/full/file%3A2_file_resource_id"
120 "?v=3&alt=json&showroot=true", 121 "?v=3&alt=json&showroot=true",
121 http_request_.relative_url); 122 http_request_.relative_url);
123 scoped_ptr<base::Value> expected_json =
124 test_util::LoadJSONFile("gdata/file_entry.json");
125 ASSERT_TRUE(expected_json);
122 EXPECT_TRUE(result_data); 126 EXPECT_TRUE(result_data);
123 EXPECT_EQ("File 1.mp3", result_data->filename()); 127 EXPECT_TRUE(base::Value::Equals(expected_json.get(), result_data.get()));
124 EXPECT_EQ("3b4382ebefec6e743578c76bbd0575ce", result_data->file_md5());
125 } 128 }
126 129
127 TEST_F(GDataWapiRequestsTest, GetResourceEntryRequest_InvalidResourceId) { 130 TEST_F(GDataWapiRequestsTest, GetResourceEntryRequest_InvalidResourceId) {
128 GDataErrorCode result_code = GDATA_OTHER_ERROR; 131 GDataErrorCode result_code = GDATA_OTHER_ERROR;
129 scoped_ptr<ResourceEntry> result_data; 132 scoped_ptr<base::Value> result_data;
130 133
131 { 134 {
132 base::RunLoop run_loop; 135 base::RunLoop run_loop;
133 GetResourceEntryRequest* request = new GetResourceEntryRequest( 136 GetResourceEntryRequest* request = new GetResourceEntryRequest(
134 request_sender_.get(), 137 request_sender_.get(),
135 *url_generator_, 138 *url_generator_,
136 "<invalid>", // resource ID 139 "<invalid>", // resource ID
137 GURL(), // embed origin 140 GURL(), // embed origin
138 test_util::CreateQuitCallback( 141 test_util::CreateQuitCallback(
139 &run_loop, 142 &run_loop,
140 test_util::CreateCopyResultCallback(&result_code, &result_data))); 143 test_util::CreateCopyResultCallback(&result_code, &result_data)));
141 request_sender_->StartRequestWithRetry(request); 144 request_sender_->StartRequestWithRetry(request);
142 run_loop.Run(); 145 run_loop.Run();
143 } 146 }
144 147
145 EXPECT_EQ(HTTP_NOT_FOUND, result_code); 148 EXPECT_EQ(HTTP_NOT_FOUND, result_code);
146 EXPECT_EQ(net::test_server::METHOD_GET, http_request_.method); 149 EXPECT_EQ(net::test_server::METHOD_GET, http_request_.method);
147 EXPECT_EQ("/feeds/default/private/full/%3Cinvalid%3E?v=3&alt=json" 150 EXPECT_EQ("/feeds/default/private/full/%3Cinvalid%3E?v=3&alt=json"
148 "&showroot=true", 151 "&showroot=true",
149 http_request_.relative_url); 152 http_request_.relative_url);
150 ASSERT_FALSE(result_data); 153 ASSERT_FALSE(result_data);
151 } 154 }
152 155
153 } // namespace google_apis 156 } // namespace google_apis
OLDNEW
« no previous file with comments | « trunk/src/google_apis/drive/gdata_wapi_requests.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698