Parse Drive API responses all at once in the blocking pool.

Reland: Parse Drive API responses all at once in the blocking pool.

Previous implementation did the parsing of string to base::Value
on blocking pool, and that of base::Value to specific data types
either on UI thread or on yet another post to blocking pool.

The previous implementation is slightly inefficient and moreover
involves a subtle bug 284244.

BUG=284244, 401843
This CL once landed as r288017 (Patch Set 4) and reverted.
This is the second try.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288275

[kinaba, 2014-08-06 08:00:30]

PTAL.

Suggestions are welcome. I'm not so sure if this is the best approach.

[hashimoto, 2014-08-06 09:23:02]

A lot of code in the header seems not pretty, but this might be the most
straight forward solution.
lgtm

https://codereview.chromium.org/442193002/diff/60001/google_apis/drive/drive_...
File google_apis/drive/drive_api_requests.h (right):

https://codereview.chromium.org/442193002/diff/60001/google_apis/drive/drive_...
google_apis/drive/drive_api_requests.h:75: class DriveApiDataRequest : public
DriveApiPartialFieldRequest {
This class is replicating GetDataRequest and, after this change, GetDataRequest
is only inherited by GetResourceEntryRequest.
Could you get rid of GetDataRequest?

[kinaba, 2014-08-07 00:59:34]

https://codereview.chromium.org/442193002/diff/60001/google_apis/drive/drive_...
File google_apis/drive/drive_api_requests.h (right):

https://codereview.chromium.org/442193002/diff/60001/google_apis/drive/drive_...
google_apis/drive/drive_api_requests.h:75: class DriveApiDataRequest : public
DriveApiPartialFieldRequest {
On 2014/08/06 09:23:02, hashimoto wrote:
> This class is replicating GetDataRequest and, after this change,
GetDataRequest
> is only inherited by GetResourceEntryRequest.
> Could you get rid of GetDataRequest?

sg. done.

[hashimoto, 2014-08-07 02:55:09]

lgtm

https://codereview.chromium.org/442193002/diff/120001/chrome/browser/drive/dr...
File chrome/browser/drive/drive_api_service.cc (right):

https://codereview.chromium.org/442193002/diff/120001/chrome/browser/drive/dr...
chrome/browser/drive/drive_api_service.cc:156: 
nit: This blank line is redundant?

[kinaba, 2014-08-07 02:58:08]

https://codereview.chromium.org/442193002/diff/120001/chrome/browser/drive/dr...
File chrome/browser/drive/drive_api_service.cc (right):

https://codereview.chromium.org/442193002/diff/120001/chrome/browser/drive/dr...
chrome/browser/drive/drive_api_service.cc:156: 
On 2014/08/07 02:55:09, hashimoto wrote:
> nit: This blank line is redundant?

Done.

[kinaba, 2014-08-07 02:58:18]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-08-07 03:01:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/442193002/140001

[commit-bot: I haz the power, 2014-08-07 06:26:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-07 08:54:55]

Change committed as 288017

[kinaba, 2014-08-08 04:33:49]

On 2014/08/07 08:54:55, I haz the power (commit-bot) wrote:
> Change committed as 288017

(reopening for relanding...)

[kinaba, 2014-08-08 06:29:30]

PTAL: Patch Set 4->5 is the diff.

[hashimoto, 2014-08-08 06:31:20]

lgtm
so sorry I couldn't catch this.

[kinaba, 2014-08-08 06:33:28]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-08-08 06:36:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/442193002/180001

[commit-bot: I haz the power, 2014-08-08 09:19:28]

Change committed as 288275