Remove OmniboxHUPCullRedirects and OmniboxHUPCreateShorterMatch trials

Remove OmniboxHUPCullRedirects and OmniboxHUPCreateShorterMatch trials

BUG=401218
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287960

[Mark P, 2014-08-06 20:13:41]

https://codereview.chromium.org/446973003/diff/1/chrome/browser/omnibox/omnib...
File chrome/browser/omnibox/omnibox_field_trial.h (right):

https://codereview.chromium.org/446973003/diff/1/chrome/browser/omnibox/omnib...
chrome/browser/omnibox/omnibox_field_trial.h:95: static void
ActivateStaticTrials();
How does this compile if you deleted the function implementation in the .cc and
left the declaration here?

Please delete this too (and answer my question while you're at it).

https://codereview.chromium.org/446973003/diff/1/chrome/browser/omnibox/omnib...
chrome/browser/omnibox/omnibox_field_trial.h:103: static void
ActivateDynamicTrials();
Please revise the above comment in light of deleting for the earlier function.

[Mark P, 2014-08-06 20:14:07]

Also, please add a bug label if appropriate.

[Steven Holte, 2014-08-06 20:43:13]

https://codereview.chromium.org/446973003/diff/1/chrome/browser/omnibox/omnib...
File chrome/browser/omnibox/omnibox_field_trial.h (right):

https://codereview.chromium.org/446973003/diff/1/chrome/browser/omnibox/omnib...
chrome/browser/omnibox/omnibox_field_trial.h:95: static void
ActivateStaticTrials();
On 2014/08/06 20:13:40, Mark P wrote:
> How does this compile if you deleted the function implementation in the .cc
and
> left the declaration here?
> 
> Please delete this too (and answer my question while you're at it).

Done.  It compiles regardless because there are no references to it, which is
what would lead the linker to actually go looking for it.

https://codereview.chromium.org/446973003/diff/1/chrome/browser/omnibox/omnib...
chrome/browser/omnibox/omnibox_field_trial.h:103: static void
ActivateDynamicTrials();
On 2014/08/06 20:13:40, Mark P wrote:
> Please revise the above comment in light of deleting for the earlier function.

Done.

[Mark P, 2014-08-06 20:47:03]

Please upload the new patchset.

thanks,
mark

[Steven Holte, 2014-08-06 20:55:50]

Oops, uploaded.  +asvitkine for chrome/browser/chrome_browser_field_trials

[Alexei Svitkine (slow), 2014-08-06 20:59:56]

LGTM, but please wait for Mark's review.

Thanks for the cleanup!

[Mark P, 2014-08-06 21:20:32]

lgtm

[Steven Holte, 2014-08-06 22:23:21]

The CQ bit was checked by holte@chromium.org

[commit-bot: I haz the power, 2014-08-06 22:25:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/holte@chromium.org/446973003/20001

[commit-bot: I haz the power, 2014-08-07 03:43:16]

Change committed as 287960