Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: chrome/browser/omnibox/omnibox_field_trial.h

Issue 446973003: Remove OmniboxHUPCullRedirects and OmniboxHUPCreateShorterMatch trials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/omnibox/omnibox_field_trial.h
diff --git a/chrome/browser/omnibox/omnibox_field_trial.h b/chrome/browser/omnibox/omnibox_field_trial.h
index e1e36f067b13fa4749932fe1b7ffe916d31c0854..1a02ebe05a726c853fd57f2ee8727e7aca9be0cd 100644
--- a/chrome/browser/omnibox/omnibox_field_trial.h
+++ b/chrome/browser/omnibox/omnibox_field_trial.h
@@ -90,16 +90,12 @@ class OmniboxFieldTrial {
// given number. Omitted types are assumed to have multipliers of 1.0.
typedef std::map<AutocompleteMatchType::Type, float> DemotionMultipliers;
- // Creates the static field trial groups.
- // *** MUST NOT BE CALLED MORE THAN ONCE. ***
- static void ActivateStaticTrials();
-
// Activates all dynamic field trials. The main difference between
// the autocomplete dynamic and static field trials is that the former
// don't require any code changes on the Chrome side as they are controlled
// on the server side. Chrome binary simply propagates all necessary
// information through the X-Client-Data header.
- // This method, unlike ActivateStaticTrials(), may be called multiple times.
+ // This method may be called multiple times.
static void ActivateDynamicTrials();
// Returns a bitmap containing AutocompleteProvider::Type values
@@ -123,29 +119,6 @@ class OmniboxFieldTrial {
std::vector<uint32>* field_trial_hash);
// ---------------------------------------------------------
- // For the HistoryURL provider disable culling redirects field trial.
-
- // Returns whether the user is in any group for this field trial.
- // (Should always be true unless initialization went wrong.)
- static bool InHUPCullRedirectsFieldTrial();
-
- // Returns whether we should disable culling of redirects in
- // HistoryURL provider.
- static bool InHUPCullRedirectsFieldTrialExperimentGroup();
-
- // ---------------------------------------------------------
- // For the HistoryURL provider disable creating a shorter match
- // field trial.
-
- // Returns whether the user is in any group for this field trial.
- // (Should always be true unless initialization went wrong.)
- static bool InHUPCreateShorterMatchFieldTrial();
-
- // Returns whether we should disable creating a shorter match in
- // HistoryURL provider.
- static bool InHUPCreateShorterMatchFieldTrialExperimentGroup();
-
- // ---------------------------------------------------------
// For the AutocompleteController "stop timer" field trial.
// Returns the duration to be used for the AutocompleteController's stop
« no previous file with comments | « chrome/browser/chrome_browser_field_trials_desktop.cc ('k') | chrome/browser/omnibox/omnibox_field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698