Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: chrome/browser/autocomplete/history_url_provider.cc

Issue 446973003: Remove OmniboxHUPCullRedirects and OmniboxHUPCreateShorterMatch trials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/history_url_provider.cc
diff --git a/chrome/browser/autocomplete/history_url_provider.cc b/chrome/browser/autocomplete/history_url_provider.cc
index bb2f3060e9ec5bf1d0268a44fa6aa6b2a3622b57..dbbff9851caed153e7ca4706fcfc033aea73a4e5 100644
--- a/chrome/browser/autocomplete/history_url_provider.cc
+++ b/chrome/browser/autocomplete/history_url_provider.cc
@@ -478,14 +478,7 @@ HistoryURLProvider::HistoryURLProvider(AutocompleteProviderListener* listener,
Profile* profile)
: HistoryProvider(profile, AutocompleteProvider::TYPE_HISTORY_URL),
listener_(listener),
- params_(NULL),
- cull_redirects_(
- !OmniboxFieldTrial::InHUPCullRedirectsFieldTrial() ||
- !OmniboxFieldTrial::InHUPCullRedirectsFieldTrialExperimentGroup()),
- create_shorter_match_(
- !OmniboxFieldTrial::InHUPCreateShorterMatchFieldTrial() ||
- !OmniboxFieldTrial::
- InHUPCreateShorterMatchFieldTrialExperimentGroup()) {
+ params_(NULL) {
// Initialize HUP scoring params based on the current experiment.
OmniboxFieldTrial::GetExperimentalHUPScoringParams(&scoring_params_);
}
@@ -823,7 +816,7 @@ void HistoryURLProvider::DoAutocomplete(history::HistoryBackend* backend,
const size_t max_results =
kMaxMatches + (params->exact_suggestion_is_in_history ? 1 : 0);
- if (backend && cull_redirects_) {
+ if (backend) {
// Remove redirects and trim list to size. We want to provide up to
// kMaxMatches results plus the What You Typed result, if it was added to
// params->matches above.
@@ -1055,8 +1048,7 @@ bool HistoryURLProvider::PromoteOrCreateShorterSuggestion(
const bool ensure_can_inline =
promote && CanPromoteMatchForInlineAutocomplete(match);
return CreateOrPromoteMatch(info, match.input_location, match.match_in_scheme,
- &params->matches, create_shorter_match_,
- promote) &&
+ &params->matches, true, promote) &&
ensure_can_inline;
}
« no previous file with comments | « chrome/browser/autocomplete/history_url_provider.h ('k') | chrome/browser/chrome_browser_field_trials_desktop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698