Remove OmniboxHUPCullRedirects and OmniboxHUPCreateShorterMatch trials

chrome/browser/omnibox/omnibox_field_trial.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 #define CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 74 matching lines @@
 // This class manages the Omnibox field trials.
 class OmniboxFieldTrial {
  public:
   // A mapping that contains multipliers indicating that matches of the
   // specified type should have their relevance score multiplied by the
   // given number.  Omitted types are assumed to have multipliers of 1.0.
   typedef std::map<AutocompleteMatchType::Type, float> DemotionMultipliers;
 
   // Creates the static field trial groups.
   // *** MUST NOT BE CALLED MORE THAN ONCE. ***
   static void ActivateStaticTrials();

[Mark P, 2014/08/06 20:13:40]

How does this compile if you deleted the function implementation in the .cc and
left the declaration here?

Please delete this too (and answer my question while you're at it).

[Steven Holte, 2014/08/06 20:43:12]

Done.  It compiles regardless because there are no references to it, which is
what would lead the linker to actually go looking for it.

 
   // Activates all dynamic field trials.  The main difference between
   // the autocomplete dynamic and static field trials is that the former
   // don't require any code changes on the Chrome side as they are controlled
   // on the server side.  Chrome binary simply propagates all necessary
   // information through the X-Client-Data header.
   // This method, unlike ActivateStaticTrials(), may be called multiple times.
   static void ActivateDynamicTrials();

[Mark P, 2014/08/06 20:13:40]

Please revise the above comment in light of deleting for the earlier function.

[Steven Holte, 2014/08/06 20:43:12]

Done.

 
   // Returns a bitmap containing AutocompleteProvider::Type values
   // that should be disabled in AutocompleteController.
   // This method simply goes over all autocomplete dynamic field trial groups
   // and looks for group names like "ProvidersDisabled_NNN" where NNN is
   // an integer corresponding to a bitmap mask.  All extracted bitmaps
   // are OR-ed together and returned as the final result.
   static int GetDisabledProviderTypes();
 
   // Returns whether the user is in any dynamic field trial where the
   // group has a the prefix |group_prefix|.
   static bool HasDynamicFieldTrialGroupPrefix(const char *group_prefix);
 
   // ---------------------------------------------------------
   // For the suggest field trial.
 
   // Populates |field_trial_hash| with hashes of the active suggest field trial
   // names, if any.
   static void GetActiveSuggestFieldTrialHashes(
       std::vector<uint32>* field_trial_hash);
 
   // ---------------------------------------------------------
-  // For the HistoryURL provider disable culling redirects field trial.
-
-  // Returns whether the user is in any group for this field trial.
-  // (Should always be true unless initialization went wrong.)
-  static bool InHUPCullRedirectsFieldTrial();
-
-  // Returns whether we should disable culling of redirects in
-  // HistoryURL provider.
-  static bool InHUPCullRedirectsFieldTrialExperimentGroup();
-
-  // ---------------------------------------------------------
-  // For the HistoryURL provider disable creating a shorter match
-  // field trial.
-
-  // Returns whether the user is in any group for this field trial.
-  // (Should always be true unless initialization went wrong.)
-  static bool InHUPCreateShorterMatchFieldTrial();
-
-  // Returns whether we should disable creating a shorter match in
-  // HistoryURL provider.
-  static bool InHUPCreateShorterMatchFieldTrialExperimentGroup();
-
-  // ---------------------------------------------------------
   // For the AutocompleteController "stop timer" field trial.
 
   // Returns the duration to be used for the AutocompleteController's stop
   // timer.  Returns the default value of 1.5 seconds if the stop timer
   // override experiment isn't active or if parsing the experiment-provided
   // duration fails.
   static base::TimeDelta StopTimerFieldTrialDuration();
 
   // ---------------------------------------------------------
   // For the ZeroSuggestProvider field trial.
@@ skipping 206 matching lines @@
   // prioritize different wildcard contexts, see the implementation.  How to
   // interpret the value is left to the caller; this is rule-dependent.
   static std::string GetValueForRuleInContext(
       const std::string& rule,
       metrics::OmniboxEventProto::PageClassification page_classification);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
 };
 
 #endif  // CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_