Issue 443303006: Pass a struct of functions instead of a function to the compressed blitter

Issue 443303006: Pass a struct of functions instead of a function to the compressed blitter (Closed)

Created:
6 years, 4 months ago by krajcevski

Modified:
6 years, 4 months ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Pass a struct of functions instead of a function to the compressed blitter Committed: https://skia.googlesource.com/skia/+/45a0bf505914adf0ee8c69e2647230618bbb3a63

Patch Set 2 : Added comments #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -12 lines)			Patch
M	src/utils/SkTextureCompressor_ASTC.cpp	View	1	2 chunks	+18 lines, -1 line	0 comments	Download
M	src/utils/SkTextureCompressor_Blitter.h	View		4 chunks	+23 lines, -9 lines	0 comments	Download
M	src/utils/SkTextureCompressor_LATC.cpp	View	1	2 chunks	+18 lines, -1 line	0 comments	Download
M	src/utils/SkTextureCompressor_R11EAC.cpp	View	1	2 chunks	+18 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + comment request https://codereview.chromium.org/443303006/diff/1/src/utils/SkTextureCompressor_ASTC.cpp File src/utils/SkTextureCompressor_ASTC.cpp (right): https://codereview.chromium.org/443303006/diff/1/src/utils/SkTextureCompressor_ASTC.cpp#newcode1993 src/utils/SkTextureCompressor_ASTC.cpp:1993: Add a comment like the ...

6 years, 4 months ago (2014-08-07 17:53:15 UTC) #2

krajcevski

https://codereview.chromium.org/443303006/diff/1/src/utils/SkTextureCompressor_ASTC.cpp File src/utils/SkTextureCompressor_ASTC.cpp (right): https://codereview.chromium.org/443303006/diff/1/src/utils/SkTextureCompressor_ASTC.cpp#newcode1993 src/utils/SkTextureCompressor_ASTC.cpp:1993: On 2014/08/07 17:53:15, robertphillips wrote: > Add a comment ...

6 years, 4 months ago (2014-08-07 18:00:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/443303006/20001

6 years, 4 months ago (2014-08-07 18:01:39 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-07 18:10:30 UTC) #6

Message was sent while issue was closed.

Change committed as 45a0bf505914adf0ee8c69e2647230618bbb3a63

Expand Messages | Collapse Messages