Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 441063003: Run microtasks at the end of each worker task. (Closed)

Created:
6 years, 4 months ago by yhirano
Modified:
6 years, 4 months ago
Reviewers:
jrummell, adamk
CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, falken, horo+watch_chromium.org, kinuko+worker_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Run microtasks at the end of each worker task. This CL adds a TaskObserver that run Microtasks at the end of each Task to WorkerThread. This CL also fixes a Promise resolution timing issue caused by V8RecursionScope in the ScriptPromiseResolver implementation. Because the microtask running timing has changed, We fix affected tests. BUG=374772 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179922

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Messages

Total messages: 12 (0 generated)
yhirano
6 years, 4 months ago (2014-08-08 05:52:25 UTC) #1
yhirano
jrummel@, This CL change the timing when promise handlers are called. Previously, they were called ...
6 years, 4 months ago (2014-08-08 05:57:40 UTC) #2
adamk
lgtm!
6 years, 4 months ago (2014-08-08 16:51:51 UTC) #3
jrummell
I like the change. LayoutTests/media LGTM.
6 years, 4 months ago (2014-08-08 16:58:03 UTC) #4
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 4 months ago (2014-08-11 03:27:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/441063003/60001
6 years, 4 months ago (2014-08-11 03:27:42 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-11 04:29:12 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 05:34:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21957)
6 years, 4 months ago (2014-08-11 05:34:02 UTC) #9
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 4 months ago (2014-08-11 07:36:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/441063003/100001
6 years, 4 months ago (2014-08-11 07:36:41 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 08:34:10 UTC) #12
Message was sent while issue was closed.
Change committed as 179922

Powered by Google App Engine
This is Rietveld 408576698