Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

Issue 441063003: Run microtasks at the end of each worker task. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptPromiseResolver.cpp ('k') | Source/core/workers/WorkerThread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
diff --git a/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp b/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
index bdc7bfec42d8c2293a45262581a0ee3d58f3fd8d..73e1709fedd128d11bd3a01d7a4b3574619c35c1 100644
--- a/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
+++ b/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
@@ -104,11 +104,8 @@ TEST_F(ScriptPromiseResolverTest, resolve)
EXPECT_TRUE(resolver->promise().isEmpty());
}
- // FIXME: http://crbug.com/374772
- // These assertions should pass, but currently RunMicrotasks run in
- // ScriptPromiseResolver::resolve wrongly.
- // EXPECT_EQ(String(), onFulfilled);
- // EXPECT_EQ(String(), onRejected);
+ EXPECT_EQ(String(), onFulfilled);
+ EXPECT_EQ(String(), onRejected);
isolate()->RunMicrotasks();
@@ -155,11 +152,8 @@ TEST_F(ScriptPromiseResolverTest, reject)
EXPECT_TRUE(resolver->promise().isEmpty());
}
- // FIXME: http://crbug.com/374772
- // These assertions should pass, but currently RunMicrotasks run in
- // ScriptPromiseResolver::reject wrongly.
- // EXPECT_EQ(String(), onFulfilled);
- // EXPECT_EQ(String(), onRejected);
+ EXPECT_EQ(String(), onFulfilled);
+ EXPECT_EQ(String(), onRejected);
isolate()->RunMicrotasks();
« no previous file with comments | « Source/bindings/core/v8/ScriptPromiseResolver.cpp ('k') | Source/core/workers/WorkerThread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698