Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: Source/bindings/core/v8/ScriptPromiseResolver.cpp

Issue 441063003: Run microtasks at the end of each worker task. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptPromiseResolver.cpp
diff --git a/Source/bindings/core/v8/ScriptPromiseResolver.cpp b/Source/bindings/core/v8/ScriptPromiseResolver.cpp
index 069cd60599173c880a085a94866449ea290b7169..2e2f7be95ccc5028fb55aa2c270db0724cbefee8 100644
--- a/Source/bindings/core/v8/ScriptPromiseResolver.cpp
+++ b/Source/bindings/core/v8/ScriptPromiseResolver.cpp
@@ -64,10 +64,6 @@ void ScriptPromiseResolver::resolveOrRejectImmediately()
ASSERT(!executionContext()->activeDOMObjectsAreStopped());
ASSERT(!executionContext()->activeDOMObjectsAreSuspended());
{
- // FIXME: The V8RecursionScope is only necessary to force microtask delivery for promises
- // resolved or rejected in workers. It can be removed once worker threads run microtasks
- // at the end of every task (rather than just the main thread).
- V8RecursionScope scope(m_scriptState->isolate(), m_scriptState->executionContext());
if (m_state == Resolving) {
m_resolver.resolve(m_value.newLocal(m_scriptState->isolate()));
} else {

Powered by Google App Engine
This is Rietveld 408576698