Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

Issue 441063003: Run microtasks at the end of each worker task. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptPromiseResolver.cpp ('k') | Source/core/workers/WorkerThread.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "bindings/core/v8/ScriptPromiseResolver.h" 6 #include "bindings/core/v8/ScriptPromiseResolver.h"
7 7
8 #include "bindings/core/v8/ScriptFunction.h" 8 #include "bindings/core/v8/ScriptFunction.h"
9 #include "bindings/core/v8/ScriptValue.h" 9 #include "bindings/core/v8/ScriptValue.h"
10 #include "bindings/core/v8/V8Binding.h" 10 #include "bindings/core/v8/V8Binding.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 EXPECT_EQ(String(), onFulfilled); 97 EXPECT_EQ(String(), onFulfilled);
98 EXPECT_EQ(String(), onRejected); 98 EXPECT_EQ(String(), onRejected);
99 99
100 resolver->resolve("hello"); 100 resolver->resolve("hello");
101 101
102 { 102 {
103 ScriptState::Scope scope(scriptState()); 103 ScriptState::Scope scope(scriptState());
104 EXPECT_TRUE(resolver->promise().isEmpty()); 104 EXPECT_TRUE(resolver->promise().isEmpty());
105 } 105 }
106 106
107 // FIXME: http://crbug.com/374772 107 EXPECT_EQ(String(), onFulfilled);
108 // These assertions should pass, but currently RunMicrotasks run in 108 EXPECT_EQ(String(), onRejected);
109 // ScriptPromiseResolver::resolve wrongly.
110 // EXPECT_EQ(String(), onFulfilled);
111 // EXPECT_EQ(String(), onRejected);
112 109
113 isolate()->RunMicrotasks(); 110 isolate()->RunMicrotasks();
114 111
115 EXPECT_EQ("hello", onFulfilled); 112 EXPECT_EQ("hello", onFulfilled);
116 EXPECT_EQ(String(), onRejected); 113 EXPECT_EQ(String(), onRejected);
117 114
118 resolver->resolve("bye"); 115 resolver->resolve("bye");
119 resolver->reject("bye"); 116 resolver->reject("bye");
120 isolate()->RunMicrotasks(); 117 isolate()->RunMicrotasks();
121 118
(...skipping 26 matching lines...) Expand all
148 EXPECT_EQ(String(), onFulfilled); 145 EXPECT_EQ(String(), onFulfilled);
149 EXPECT_EQ(String(), onRejected); 146 EXPECT_EQ(String(), onRejected);
150 147
151 resolver->reject("hello"); 148 resolver->reject("hello");
152 149
153 { 150 {
154 ScriptState::Scope scope(scriptState()); 151 ScriptState::Scope scope(scriptState());
155 EXPECT_TRUE(resolver->promise().isEmpty()); 152 EXPECT_TRUE(resolver->promise().isEmpty());
156 } 153 }
157 154
158 // FIXME: http://crbug.com/374772 155 EXPECT_EQ(String(), onFulfilled);
159 // These assertions should pass, but currently RunMicrotasks run in 156 EXPECT_EQ(String(), onRejected);
160 // ScriptPromiseResolver::reject wrongly.
161 // EXPECT_EQ(String(), onFulfilled);
162 // EXPECT_EQ(String(), onRejected);
163 157
164 isolate()->RunMicrotasks(); 158 isolate()->RunMicrotasks();
165 159
166 EXPECT_EQ(String(), onFulfilled); 160 EXPECT_EQ(String(), onFulfilled);
167 EXPECT_EQ("hello", onRejected); 161 EXPECT_EQ("hello", onRejected);
168 162
169 resolver->resolve("bye"); 163 resolver->resolve("bye");
170 resolver->reject("bye"); 164 resolver->reject("bye");
171 isolate()->RunMicrotasks(); 165 isolate()->RunMicrotasks();
172 166
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 resolver->reject(); 305 resolver->reject();
312 isolate()->RunMicrotasks(); 306 isolate()->RunMicrotasks();
313 307
314 EXPECT_EQ(String(), onFulfilled); 308 EXPECT_EQ(String(), onFulfilled);
315 EXPECT_EQ("undefined", onRejected); 309 EXPECT_EQ("undefined", onRejected);
316 } 310 }
317 311
318 } // namespace 312 } // namespace
319 313
320 } // namespace blink 314 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/ScriptPromiseResolver.cpp ('k') | Source/core/workers/WorkerThread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698