Move output of [OK] and [FAILED] from AddValue to DidRunPage for gtest output.

Move output of [OK] and [FAILED] from AddValue to DidRunPage for gtest output.

Kill AddSuccess and GTestTestResults (the latter is already unused, but
was left out from deletion during
https://codereview.chromium.org/430383003/)

BUG=383639
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287486

[nednguyen, 2014-08-04 23:42:59]

lgtm

https://codereview.chromium.org/439553002/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/results/gtest_progress_reporter.py (right):

https://codereview.chromium.org/439553002/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/results/gtest_progress_reporter.py:32:
logging.warning('===== SKIPPING TEST %s: %s =====',
Should be SKIPPING TEST RUN, I think.
And why do we still logging.warning this instead of putting it on
self.output_stream?

https://codereview.chromium.org/439553002/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/results/gtest_progress_reporter.py:61: print >>
self.output_stream, '=== RETRYING PAGE RUN ==='
Would be nice if we can plumb the number of attempt left to here.

https://codereview.chromium.org/439553002/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py
(right):

https://codereview.chromium.org/439553002/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py:136: 
Can you add a unittest cover for gtest_progresss_reporter.WillAttemptPageRun?

[chrishenry, 2014-08-05 00:17:49]

https://codereview.chromium.org/439553002/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/results/gtest_progress_reporter.py (right):

https://codereview.chromium.org/439553002/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/results/gtest_progress_reporter.py:32:
logging.warning('===== SKIPPING TEST %s: %s =====',
On 2014/08/04 23:42:59, nednguyen wrote:
> Should be SKIPPING TEST RUN, I think.
> And why do we still logging.warning this instead of putting it on
> self.output_stream?

Good catch. Didn't update after copy pasting.

https://codereview.chromium.org/439553002/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/results/gtest_progress_reporter.py:61: print >>
self.output_stream, '=== RETRYING PAGE RUN ==='
On 2014/08/04 23:42:59, nednguyen wrote:
> Would be nice if we can plumb the number of attempt left to here.

Was thinking of plumbing attempt_count here already so that I don't need to do
the roundabout check of current_page_run.ok, should be easy enough to also wire
up max_attempt_count. Done.

https://codereview.chromium.org/439553002/diff/120001/tools/telemetry/telemet...
File tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py
(right):

https://codereview.chromium.org/439553002/diff/120001/tools/telemetry/telemet...
tools/telemetry/telemetry/results/gtest_progress_reporter_unittest.py:136: 
On 2014/08/04 23:42:59, nednguyen wrote:
> Can you add a unittest cover for gtest_progresss_reporter.WillAttemptPageRun?

Done.

[chrishenry, 2014-08-05 00:18:42]

The CQ bit was checked by chrishenry@google.com

[commit-bot: I haz the power, 2014-08-05 00:20:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishenry@google.com/439553002/180001

[commit-bot: I haz the power, 2014-08-05 05:41:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[commit-bot: I haz the power, 2014-08-05 07:55:57]

Change committed as 287486