tools/telemetry/telemetry/results/html_output_formatter_unittest.py - Issue 439553002: Move output of [OK] and [FAILED] from AddValue to DidRunPage for gtest output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/html_output_formatter_unittest.py

Issue 439553002: Move output of [OK] and [FAILED] from AddValue to DidRunPage for gtest output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/gtest_test_results_unittest.py ('k') | tools/telemetry/telemetry/results/page_test_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/html_output_formatter_unittest.py

diff --git a/tools/telemetry/telemetry/results/html_output_formatter_unittest.py b/tools/telemetry/telemetry/results/html_output_formatter_unittest.py

index 8b4b0a0cc7e13be73418e6948ccd57551eff77cb..5d6dfa7f5ed52d3e76faaf4e63740a2e4e4d50c0 100644

--- a/tools/telemetry/telemetry/results/html_output_formatter_unittest.py

+++ b/tools/telemetry/telemetry/results/html_output_formatter_unittest.py

@@ -44,13 +44,11 @@ class HtmlOutputFormatterTest(unittest.TestCase):

results.WillRunPage(test_page_set.pages[0])

results.AddValue(scalar.ScalarValue(

test_page_set.pages[0], 'a', 'seconds', 3))

- results.AddSuccess(test_page_set.pages[0])

results.DidRunPage(test_page_set.pages[0])

results.WillRunPage(test_page_set.pages[1])

results.AddValue(scalar.ScalarValue(

test_page_set.pages[1], 'a', 'seconds', 7))

- results.AddSuccess(test_page_set.pages[1])

results.DidRunPage(test_page_set.pages[1])

formatter = DeterministicHtmlOutputFormatter(

@@ -101,13 +99,11 @@ class HtmlOutputFormatterTest(unittest.TestCase):

results.WillRunPage(test_page_set.pages[0])

results.AddValue(scalar.ScalarValue(

test_page_set.pages[0], 'a', 'seconds', 4))

- results.AddSuccess(test_page_set.pages[0])

results.DidRunPage(test_page_set.pages[0])

results.WillRunPage(test_page_set.pages[1])

results.AddValue(scalar.ScalarValue(

test_page_set.pages[1], 'a', 'seconds', 8))

- results.AddSuccess(test_page_set.pages[1])

results.DidRunPage(test_page_set.pages[1])

formatter = DeterministicHtmlOutputFormatter(

@@ -197,13 +193,11 @@ class HtmlOutputFormatterTest(unittest.TestCase):

results.WillRunPage(test_page_set.pages[0])

results.AddValue(scalar.ScalarValue(

test_page_set.pages[0], 'a', 'seconds', 5))

- results.AddSuccess(test_page_set.pages[0])

results.DidRunPage(test_page_set.pages[0])

results.WillRunPage(test_page_set.pages[1])

results.AddValue(scalar.ScalarValue(

test_page_set.pages[1], 'a', 'seconds', 9))

- results.AddSuccess(test_page_set.pages[1])

results.DidRunPage(test_page_set.pages[1])

formatter = DeterministicHtmlOutputFormatter(