Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py

Issue 439553002: Move output of [OK] and [FAILED] from AddValue to DidRunPage for gtest output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | tools/telemetry/telemetry/results/gtest_progress_reporter.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py
diff --git a/tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py b/tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py
index af0e2c423851bdd2eeaffbeb55aa4cd0bf0635b3..60e53ef176df55c95d8fab08bfc5c6fb8c6eef4d 100644
--- a/tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py
+++ b/tools/telemetry/telemetry/results/buildbot_output_formatter_unittest.py
@@ -33,13 +33,11 @@ class BuildbotOutputFormatterTest(
measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 7))
- measurement_results.AddSuccess(test_page_set.pages[1])
measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
@@ -63,7 +61,6 @@ class BuildbotOutputFormatterTest(
measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
@@ -86,7 +83,6 @@ class BuildbotOutputFormatterTest(
test_page_set.pages[0], 'a', 'seconds', 3))
measurement_results.AddValue(
scalar.ScalarValue(test_page_set.pages[0], 'b', 'seconds', 10))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
measurement_results.WillRunPage(test_page_set.pages[1])
@@ -94,14 +90,12 @@ class BuildbotOutputFormatterTest(
test_page_set.pages[1], 'a', 'seconds', 3))
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'b', 'seconds', 10))
- measurement_results.AddSuccess(test_page_set.pages[1])
measurement_results.DidRunPage(test_page_set.pages[1])
measurement_results.WillRunPage(test_page_set.pages[2])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[2], 'a', 'seconds', 7))
# Note, page[2] does not report a 'b' metric.
- measurement_results.AddSuccess(test_page_set.pages[2])
measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
@@ -137,7 +131,6 @@ class BuildbotOutputFormatterTest(
measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 7))
- measurement_results.AddSuccess(test_page_set.pages[1])
measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
@@ -172,13 +165,11 @@ class BuildbotOutputFormatterTest(
measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 4))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 8))
- measurement_results.AddSuccess(test_page_set.pages[1])
measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
@@ -204,25 +195,21 @@ class BuildbotOutputFormatterTest(
measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 7))
- measurement_results.AddSuccess(test_page_set.pages[1])
measurement_results.DidRunPage(test_page_set.pages[1])
measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 4))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 8))
- measurement_results.AddSuccess(test_page_set.pages[1])
measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
@@ -252,25 +239,21 @@ class BuildbotOutputFormatterTest(
measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 4))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 7))
- measurement_results.AddSuccess(test_page_set.pages[1])
measurement_results.DidRunPage(test_page_set.pages[1])
measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'a', 'seconds', 8))
- measurement_results.AddSuccess(test_page_set.pages[1])
measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
@@ -303,13 +286,11 @@ class BuildbotOutputFormatterTest(
measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'b', 'seconds', 2))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'b', 'seconds', 3))
- measurement_results.AddSuccess(test_page_set.pages[1])
measurement_results.DidRunPage(test_page_set.pages[1])
measurement_results.AddSummaryValue(
@@ -340,13 +321,11 @@ class BuildbotOutputFormatterTest(
measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'b', 'seconds', 2))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'b', 'seconds', 3))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
@@ -374,13 +353,11 @@ class BuildbotOutputFormatterTest(
measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'b', 'seconds', 2, important=False))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[1], 'b', 'seconds', 3, important=False))
- measurement_results.AddSuccess(test_page_set.pages[1])
measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
@@ -408,13 +385,11 @@ class BuildbotOutputFormatterTest(
measurement_results.WillRunPage(test_page_set.pages[0])
measurement_results.AddValue(list_of_scalar_values.ListOfScalarValues(
test_page_set.pages[0], 'b', 'seconds', [2, 2]))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
measurement_results.WillRunPage(test_page_set.pages[1])
measurement_results.AddValue(list_of_scalar_values.ListOfScalarValues(
test_page_set.pages[1], 'b', 'seconds', [3, 3]))
- measurement_results.AddSuccess(test_page_set.pages[1])
measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
@@ -442,7 +417,6 @@ class BuildbotOutputFormatterTest(
test_page_set.pages[0], 'a', 'units',
raw_value_json='{"buckets": [{"low": 1, "high": 2, "count": 1}]}',
important=False))
- measurement_results.AddSuccess(test_page_set.pages[0])
measurement_results.DidRunPage(test_page_set.pages[0])
measurement_results.WillRunPage(test_page_set.pages[1])
@@ -450,7 +424,6 @@ class BuildbotOutputFormatterTest(
test_page_set.pages[1], 'a', 'units',
raw_value_json='{"buckets": [{"low": 2, "high": 3, "count": 1}]}',
important=False))
- measurement_results.AddSuccess(test_page_set.pages[1])
measurement_results.DidRunPage(test_page_set.pages[1])
formatter = buildbot_output_formatter.BuildbotOutputFormatter(
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | tools/telemetry/telemetry/results/gtest_progress_reporter.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698