tools/telemetry/telemetry/results/page_test_results_unittest.py - Issue 439553002: Move output of [OK] and [FAILED] from AddValue to DidRunPage for gtest output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/page_test_results_unittest.py

Issue 439553002: Move output of [OK] and [FAILED] from AddValue to DidRunPage for gtest output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/page_test_results.py ('k') | tools/telemetry/telemetry/results/progress_reporter.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/page_test_results_unittest.py

diff --git a/tools/telemetry/telemetry/results/page_test_results_unittest.py b/tools/telemetry/telemetry/results/page_test_results_unittest.py

index c170c1fb0ae0af5539b15e3e721f97e54e681223..7be382b3cf6d1265273ed04d79f8aa574ed91f19 100644

--- a/tools/telemetry/telemetry/results/page_test_results_unittest.py

+++ b/tools/telemetry/telemetry/results/page_test_results_unittest.py

@@ -36,7 +36,6 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):

results.DidRunPage(self.pages[0])

results.WillRunPage(self.pages[1])

- results.AddSuccess(self.pages[1])

results.DidRunPage(self.pages[1])

self.assertEqual(set([self.pages[0]]), results.pages_that_failed)

@@ -53,7 +52,6 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):

results.DidRunPage(self.pages[0])

results.WillRunPage(self.pages[1])

- results.AddSuccess(self.pages[1])

results.DidRunPage(self.pages[1])

self.assertTrue(results.all_page_runs[0].skipped)

« no previous file with comments | « tools/telemetry/telemetry/results/page_test_results.py ('k') | tools/telemetry/telemetry/results/progress_reporter.py » ('j') | no next file with comments »