Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 439383002: Add GetThreadToInteractionRecordsMapsFromModel method to timeline_interaction_record. (Closed)

Created:
6 years, 4 months ago by nednguyen
Modified:
5 years, 11 months ago
Reviewers:
nduca, ernstm
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add GetThreadToInteractionRecordsMapsFromModel method to timeline_interaction_record. This method creates a map from render threads to the list of interaction records belong to that thread. This is nice since it allows us to: 1) Simplify the interface of timeline_based_metrics.AddResults method 2) Allows us to take measurements of interaction records belong to different threads. A potential use case is timeline_based_measurement can work for a multi tab test. 3) This allows us to remove the tab.id, the map from telemetry tab objects to render theads and the logic of issuing tab id on the timeline model, which allows us to get partial metrics for timeline_based_measurement in case trace buffer overflowed. 4) Profit!! BUG=

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -43 lines) Patch
M tools/perf/measurements/loading_trace.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/perf/measurements/smooth_gesture_util.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/measurements/smoothness_controller.py View 4 chunks +14 lines, -13 lines 0 comments Download
M tools/perf/measurements/thread_times.py View 1 chunk +1 line, -3 lines 0 comments Download
M tools/perf/measurements/timeline_controller.py View 1 chunk +10 lines, -7 lines 0 comments Download
M tools/perf/metrics/timeline.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/smoothness.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py View 2 chunks +16 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 3 chunks +10 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record.py View 4 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
nednguyen
6 years, 4 months ago (2014-08-04 18:31:00 UTC) #1
ptal to the changes in timeline_interaction_record, timeline_based_metric, 
web_perf/metrics/smoothness.py, and perf/metrics/timeline.py.

This is still a wip since not all the tests pass yet and I haven't remove the
tab.id, tab_to_renderer_thread mess in model yet but it would be helpful if you
can provide some sanity check to the approach.

Powered by Google App Engine
This is Rietveld 408576698