Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: tools/perf/metrics/timeline.py

Issue 439383002: Add GetThreadToInteractionRecordsMapsFromModel method to timeline_interaction_record. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/metrics/timeline.py
diff --git a/tools/perf/metrics/timeline.py b/tools/perf/metrics/timeline.py
index 19db3d59ad1985c1cebcc645f45719e60ae55cb0..bd292e382219c3bf7708a7a4faf301f9625d2405 100644
--- a/tools/perf/metrics/timeline.py
+++ b/tools/perf/metrics/timeline.py
@@ -12,12 +12,14 @@ class LoadTimesTimelineMetric(timeline_based_metric.TimelineBasedMetric):
super(LoadTimesTimelineMetric, self).__init__()
self.report_main_thread_only = True
- def AddResults(self, model, renderer_thread, interaction_records, results):
+ def AddResults(self, model, interaction_records, results):
assert model
assert len(interaction_records) == 1, (
'LoadTimesTimelineMetric cannot compute metrics for more than 1 time '
'range.')
+ self.VerifyAllRecordsIssuedBySameThread(interaction_records)
interaction_record = interaction_records[0]
+ renderer_thread = interaction_record.async_event.start_thread
if self.report_main_thread_only:
thread_filter = 'CrRendererMain'
else:
@@ -224,7 +226,7 @@ class ThreadTimesTimelineMetric(timeline_based_metric.TimelineBasedMetric):
count += 1
return count
- def AddResults(self, model, _, interaction_records, results):
+ def AddResults(self, model, interaction_records, results):
# Set up each thread category for consistant results.
thread_category_results = {}
for name in TimelineThreadCategories.values():
« no previous file with comments | « tools/perf/measurements/timeline_controller.py ('k') | tools/telemetry/telemetry/web_perf/metrics/smoothness.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698